[Reporting API] Test reports should go "Reporting-Endpoints" Endpoints #5216

brentfulgham · 2022-10-11T00:10:54Z

`8ae6f49`

[Reporting API] Test reports should go "Reporting-Endpoints" Endpoints
https://bugs.webkit.org/show_bug.cgi?id=244907
<rdar://problem/99666423>

Reviewed by Chris Dumez.

Test reports should be sent to any endpoints provided in a "Reporting-Endpoints" header.
There also don't appear to be WPT that check this behavior. This patch implements
this part of the spec, and adds tests.

It also connects 'generateTestReport' to WebKitLegacy so we can exercise the code in DumpRenderTree.

* LayoutTests/http/tests/security/contentSecurityPolicy: Rebasedlined tests.
* LayoutTests/imported/w3c/web-platform-tests/reporting/generateTestReport-honors-endpoint.https.sub-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/reporting/generateTestReport-honors-endpoint.https.sub.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/reporting/generateTestReport-honors-endpoint.https.sub.html.sub.headers: Added.
* LayoutTests/imported/w3c/web-platform-tests/reporting/generateTestReport-honors-endpoint.http.sub-expected: Added.
* LayoutTests/imported/w3c/web-platform-tests/reporting/generateTestReport-honors-endpoint.http.sub.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/reporting/generateTestReport-honors-endpoint.http.sub.html.sub.headers: Added.
* LayoutTests/platform/gtk/TestExpectations: Mark http-based WPT as expected to fail.
* LayoutTests/platform/mac-wk1/TestExpectations: Mark https-based WPT as expected to fail.
* Source/WebCore/Modules/reporting/Report.cpp:
(WebCore::Report::createReportFormDataForViolation):
* Source/WebCore/Modules/reporting/Report.h:
* Source/WebCore/Modules/reporting/ReportingScope.cpp:
(WebCore::ReportingScope::generateTestReport):
* Source/WebCore/Modules/reporting/TestReportBody.cpp:
(WebCore::TestReportBody::createReportFormDataForViolation const): Deleted.
* Source/WebCore/Modules/reporting/TestReportBody.h:
* Source/WebCore/loader/CrossOriginEmbedderPolicy.cpp:
(WebCore::sendCOEPInheritenceViolation):
(WebCore::sendCOEPCORPViolation):
* Source/WebCore/loader/CrossOriginOpenerPolicy.cpp:
(WebCore::sendViolationReportWhenNavigatingToCOOPResponse):
(WebCore::sendViolationReportWhenNavigatingAwayFromCOOPResponse):
* Source/WebCore/page/csp/CSPViolationReportBody.cpp:
(WebCore::CSPViolationReportBody::createReportFormDataForViolation const):
* Source/WebCore/page/csp/CSPViolationReportBody.h:
* Source/WebCore/page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::reportViolation const):
* Source/WebKitLegacy/mac/WebView/WebFrame.mm
(-[WebFrame _generateTestReport:withGroup:]): Added.
* Source/WebKitLegacy/mac/WebView/WebFramePrivate.h
* Tools/DumpRenderTree/TestRunner.cpp
(generateTestReportCallback): Add support for 'generateTestReport'.
(TestRunner::staticFunctions): Ditto.
* Tools/DumpRenderTree/TestRunner.h
* Tools/DumpRenderTree/mac/TestRunnerMac.mm
(TestRunner::generateTestReport): Added.
* Tools/DumpRenderTree/win/TestRunnerWin.cpp
(TestRunner::generateTestReport): Added stub.

Canonical link: https://commits.webkit.org/255845@main

dc0e2cc

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	~~🛠 mac~~	✅ 🛠 wpe	✅ 🛠 🧪 win
	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	~~🛠 wincairo~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	~~🧪 gtk-wk2~~
	✅ 🧪 api-ios	~~🧪 api-mac~~	~~🧪 api-gtk~~
	✅ 🛠 tv	~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	~~🧪 mac-wk2~~
✅ 🛠 🧪 merge	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch-sim	~~🧪 mac-wk2-stress~~

webkit-early-warning-system · 2022-10-11T00:11:05Z

EWS run on previous version of this PR (hash dcf847b)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	❌ 🧪 mac-wk1
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2
	✅ 🛠 watch	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

brentfulgham · 2022-10-11T00:11:48Z

Note: This is a WIP. New tests are not in this patch yet.

webkit-early-warning-system · 2022-10-12T23:37:25Z

EWS run on previous version of this PR (hash 91819e1)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	⏳ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	⏳ 🛠 mac-debug	⏳ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	⏳ 🛠 mac-AS-debug	⏳ 🧪 gtk-wk2
	~~🧪 api-ios~~	⏳ 🧪 api-mac	⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc	⏳ 🛠 tv	⏳ 🧪 mac-wk1
	⏳ 🛠 tv-sim	⏳ 🧪 mac-wk2
	⏳ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2
	⏳ 🛠 watch-sim	⏳ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-10-12T23:42:29Z

EWS run on previous version of this PR (hash ec7e620)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	⏳ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	⏳ 🛠 mac-debug	⏳ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🛠 mac-AS-debug	⏳ 🧪 gtk-wk2
	⏳ 🧪 api-ios	⏳ 🧪 api-mac	⏳ 🧪 api-gtk
	⏳ 🛠 tv	⏳ 🧪 mac-wk1
	⏳ 🛠 tv-sim	⏳ 🧪 mac-wk2
	⏳ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	⏳ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-10-12T23:53:13Z

EWS run on previous version of this PR (hash 5191a4c)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	⏳ 🧪 api-ios	~~🧪 api-mac~~	✅ 🧪 api-gtk
	✅ 🛠 tv	❌ 🧪 mac-wk1
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2
	✅ 🛠 watch	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-10-13T19:38:47Z

EWS run on previous version of this PR (hash 4cc3cd2)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	~~🛠 mac-debug~~	⏳ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🛠 mac-AS-debug	⏳ 🧪 gtk-wk2
	~~🧪 api-ios~~	~~🧪 api-mac~~	⏳ 🧪 api-gtk
	~~🛠 tv~~	~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	~~🧪 mac-wk2~~
	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch-sim	~~🧪 mac-wk2-stress~~

cdumez · 2022-10-13T19:51:02Z

This patch implements
this part of the spec, and adds tests.

Where are the tests?

webkit-early-warning-system · 2022-10-13T19:59:02Z

EWS run on previous version of this PR (hash e7ab03b)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	❌ 🧪 mac-wk1
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2
	✅ 🛠 watch	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

brentfulgham · 2022-10-14T00:05:51Z

This patch implements
this part of the spec, and adds tests.

Where are the tests?

They should be in the PR now.

webkit-early-warning-system · 2022-10-17T22:32:36Z

EWS run on previous version of this PR (hash bda3b48)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	⏳ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 🧪 win
	✅ 🛠 ios-sim	⏳ 🛠 mac-debug	⏳ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🛠 mac-AS-debug	⏳ 🧪 gtk-wk2
	~~🧪 api-ios~~	⏳ 🧪 api-mac	⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc	⏳ 🛠 tv	⏳ 🧪 mac-wk1
	✅ 🛠 tv-sim	⏳ 🧪 mac-wk2
	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch-sim	⏳ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-10-17T22:49:32Z

EWS run on previous version of this PR (hash 5ec0faa)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	❌ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk1
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2
	✅ 🛠 watch	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-10-18T23:24:24Z

EWS run on previous version of this PR (hash 3ff1d45)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
	✅ 🛠 ios-sim	✅ 🛠 mac-debug	❌ 🛠 gtk	❌ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	❌ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-10-19T17:54:57Z

EWS run on previous version of this PR (hash 149ecb0)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	~~🧪 api-mac~~	~~🧪 api-gtk~~
	✅ 🛠 tv	~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	~~🧪 mac-wk2~~
	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-10-19T21:01:25Z

EWS run on previous version of this PR (hash c5f5fec)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	❌ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk1
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

brentfulgham · 2022-10-20T17:55:07Z

I'm skeptical of the API test failure, since the tests have been passing consistently in earlier patches, and I've only been adjusting DumpRenderTree and test cases, not engine code in recent updates.

cdumez

LGTM with minor fixes.

...s/imported/w3c/web-platform-tests/reporting/generateTestReport-honors-endpoint.http.sub.html

.../imported/w3c/web-platform-tests/reporting/generateTestReport-honors-endpoint.https.sub.html

Source/WebCore/Modules/reporting/ReportingScope.cpp

webkit-early-warning-system · 2022-10-21T19:11:05Z

EWS run on current version of this PR (hash dc0e2cc)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	~~🛠 mac~~	✅ 🛠 wpe	✅ 🛠 🧪 win
	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	~~🛠 wincairo~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	~~🧪 gtk-wk2~~
	✅ 🧪 api-ios	~~🧪 api-mac~~	~~🧪 api-gtk~~
	✅ 🛠 tv	~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	~~🧪 mac-wk2~~
✅ 🛠 🧪 merge	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch-sim	~~🧪 mac-wk2-stress~~

https://bugs.webkit.org/show_bug.cgi?id=244907 <rdar://problem/99666423> Reviewed by Chris Dumez. Test reports should be sent to any endpoints provided in a "Reporting-Endpoints" header. There also don't appear to be WPT that check this behavior. This patch implements this part of the spec, and adds tests. It also connects 'generateTestReport' to WebKitLegacy so we can exercise the code in DumpRenderTree. * LayoutTests/http/tests/security/contentSecurityPolicy: Rebasedlined tests. * LayoutTests/imported/w3c/web-platform-tests/reporting/generateTestReport-honors-endpoint.https.sub-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/reporting/generateTestReport-honors-endpoint.https.sub.html: Added. * LayoutTests/imported/w3c/web-platform-tests/reporting/generateTestReport-honors-endpoint.https.sub.html.sub.headers: Added. * LayoutTests/imported/w3c/web-platform-tests/reporting/generateTestReport-honors-endpoint.http.sub-expected: Added. * LayoutTests/imported/w3c/web-platform-tests/reporting/generateTestReport-honors-endpoint.http.sub.html: Added. * LayoutTests/imported/w3c/web-platform-tests/reporting/generateTestReport-honors-endpoint.http.sub.html.sub.headers: Added. * LayoutTests/platform/gtk/TestExpectations: Mark http-based WPT as expected to fail. * LayoutTests/platform/mac-wk1/TestExpectations: Mark https-based WPT as expected to fail. * Source/WebCore/Modules/reporting/Report.cpp: (WebCore::Report::createReportFormDataForViolation): * Source/WebCore/Modules/reporting/Report.h: * Source/WebCore/Modules/reporting/ReportingScope.cpp: (WebCore::ReportingScope::generateTestReport): * Source/WebCore/Modules/reporting/TestReportBody.cpp: (WebCore::TestReportBody::createReportFormDataForViolation const): Deleted. * Source/WebCore/Modules/reporting/TestReportBody.h: * Source/WebCore/loader/CrossOriginEmbedderPolicy.cpp: (WebCore::sendCOEPInheritenceViolation): (WebCore::sendCOEPCORPViolation): * Source/WebCore/loader/CrossOriginOpenerPolicy.cpp: (WebCore::sendViolationReportWhenNavigatingToCOOPResponse): (WebCore::sendViolationReportWhenNavigatingAwayFromCOOPResponse): * Source/WebCore/page/csp/CSPViolationReportBody.cpp: (WebCore::CSPViolationReportBody::createReportFormDataForViolation const): * Source/WebCore/page/csp/CSPViolationReportBody.h: * Source/WebCore/page/csp/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::reportViolation const): * Source/WebKitLegacy/mac/WebView/WebFrame.mm (-[WebFrame _generateTestReport:withGroup:]): Added. * Source/WebKitLegacy/mac/WebView/WebFramePrivate.h * Tools/DumpRenderTree/TestRunner.cpp (generateTestReportCallback): Add support for 'generateTestReport'. (TestRunner::staticFunctions): Ditto. * Tools/DumpRenderTree/TestRunner.h * Tools/DumpRenderTree/mac/TestRunnerMac.mm (TestRunner::generateTestReport): Added. * Tools/DumpRenderTree/win/TestRunnerWin.cpp (TestRunner::generateTestReport): Added stub. Canonical link: https://commits.webkit.org/255845@main

webkit-commit-queue · 2022-10-21T20:21:27Z

Committed 255845@main (8ae6f49): https://commits.webkit.org/255845@main

Reviewed commits have been landed. Closing PR #5216 and removing active labels.

brentfulgham requested a review from cdumez as a code owner October 11, 2022 00:10

brentfulgham self-assigned this Oct 11, 2022

brentfulgham added WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). WebKit Nightly Build labels Oct 11, 2022

brentfulgham marked this pull request as draft October 11, 2022 00:11

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 11, 2022

brentfulgham removed the merging-blocked Applied to prevent a change from being merged label Oct 12, 2022

brentfulgham force-pushed the eng/Reporting-API-Test-reports-should-go-Reporting-Endpoints-Endpoints branch from dcf847b to 91819e1 Compare October 12, 2022 23:36

brentfulgham changed the title ~~[Reporting API] Test reports should go "Reporting-Endpoints" Endpoints~~ [Reporting API] Test reports should go to "Reporting-Endpoints" Endpoints Oct 12, 2022

brentfulgham changed the title ~~[Reporting API] Test reports should go to "Reporting-Endpoints" Endpoints~~ [Reporting API] Test reports should go "Reporting-Endpoints" Endpoints Oct 12, 2022

brentfulgham changed the title ~~[Reporting API] Test reports should go "Reporting-Endpoints" Endpoints~~ Need a short description (OOPS!). Oct 12, 2022

brentfulgham force-pushed the eng/Reporting-API-Test-reports-should-go-Reporting-Endpoints-Endpoints branch from ec7e620 to 5191a4c Compare October 12, 2022 23:52

brentfulgham changed the title ~~Need a short description (OOPS!).~~ [Reporting API] Test reports should go "Reporting-Endpoints" Endpoints Oct 12, 2022

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 13, 2022

brentfulgham removed the merging-blocked Applied to prevent a change from being merged label Oct 13, 2022

brentfulgham force-pushed the eng/Reporting-API-Test-reports-should-go-Reporting-Endpoints-Endpoints branch from 5191a4c to 4cc3cd2 Compare October 13, 2022 19:36

brentfulgham marked this pull request as ready for review October 13, 2022 19:46

brentfulgham force-pushed the eng/Reporting-API-Test-reports-should-go-Reporting-Endpoints-Endpoints branch from 4cc3cd2 to e7ab03b Compare October 13, 2022 19:57

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 14, 2022

brentfulgham removed the merging-blocked Applied to prevent a change from being merged label Oct 14, 2022

brentfulgham force-pushed the eng/Reporting-API-Test-reports-should-go-Reporting-Endpoints-Endpoints branch from e7ab03b to 1fb28ee Compare October 14, 2022 20:38

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 14, 2022

brentfulgham removed the merging-blocked Applied to prevent a change from being merged label Oct 17, 2022

brentfulgham force-pushed the eng/Reporting-API-Test-reports-should-go-Reporting-Endpoints-Endpoints branch from 1fb28ee to bda3b48 Compare October 17, 2022 22:32

brentfulgham force-pushed the eng/Reporting-API-Test-reports-should-go-Reporting-Endpoints-Endpoints branch from bda3b48 to 5ec0faa Compare October 17, 2022 22:48

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 17, 2022

brentfulgham removed the merging-blocked Applied to prevent a change from being merged label Oct 18, 2022

brentfulgham force-pushed the eng/Reporting-API-Test-reports-should-go-Reporting-Endpoints-Endpoints branch from 5ec0faa to 3ff1d45 Compare October 18, 2022 23:21

brentfulgham requested a review from JonWBedard as a code owner October 18, 2022 23:21

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 19, 2022

brentfulgham removed the merging-blocked Applied to prevent a change from being merged label Oct 19, 2022

brentfulgham force-pushed the eng/Reporting-API-Test-reports-should-go-Reporting-Endpoints-Endpoints branch from 3ff1d45 to 149ecb0 Compare October 19, 2022 17:54

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 19, 2022

brentfulgham removed the merging-blocked Applied to prevent a change from being merged label Oct 19, 2022

brentfulgham force-pushed the eng/Reporting-API-Test-reports-should-go-Reporting-Endpoints-Endpoints branch from 149ecb0 to c5f5fec Compare October 19, 2022 21:00

cdumez approved these changes Oct 20, 2022

View reviewed changes

brentfulgham force-pushed the eng/Reporting-API-Test-reports-should-go-Reporting-Endpoints-Endpoints branch from c5f5fec to dc0e2cc Compare October 21, 2022 19:10

brentfulgham requested a review from rniwa as a code owner October 21, 2022 19:10

brentfulgham added the merge-queue Applied to send a pull request to merge-queue label Oct 21, 2022

webkit-early-warning-system force-pushed the eng/Reporting-API-Test-reports-should-go-Reporting-Endpoints-Endpoints branch from dc0e2cc to 8ae6f49 Compare October 21, 2022 20:21

webkit-early-warning-system merged commit 8ae6f49 into WebKit:main Oct 21, 2022

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Oct 21, 2022

[Reporting API] Test reports should go "Reporting-Endpoints" Endpoints #5216

[Reporting API] Test reports should go "Reporting-Endpoints" Endpoints #5216

Uh oh!

Conversation

brentfulgham commented Oct 11, 2022 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

8ae6f49

Uh oh!

webkit-early-warning-system commented Oct 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brentfulgham commented Oct 11, 2022

Uh oh!

webkit-early-warning-system commented Oct 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cdumez commented Oct 13, 2022

Uh oh!

webkit-early-warning-system commented Oct 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brentfulgham commented Oct 14, 2022

Uh oh!

webkit-early-warning-system commented Oct 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brentfulgham commented Oct 20, 2022

Uh oh!

cdumez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-commit-queue commented Oct 21, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

brentfulgham commented Oct 11, 2022 •

edited by webkit-early-warning-system

Loading

`8ae6f49`

webkit-early-warning-system commented Oct 11, 2022 •

edited

Loading

webkit-early-warning-system commented Oct 12, 2022 •

edited

Loading

webkit-early-warning-system commented Oct 12, 2022 •

edited

Loading

webkit-early-warning-system commented Oct 12, 2022 •

edited

Loading

webkit-early-warning-system commented Oct 13, 2022 •

edited

Loading

webkit-early-warning-system commented Oct 13, 2022 •

edited

Loading

webkit-early-warning-system commented Oct 17, 2022 •

edited

Loading

webkit-early-warning-system commented Oct 17, 2022 •

edited

Loading

webkit-early-warning-system commented Oct 18, 2022 •

edited

Loading

webkit-early-warning-system commented Oct 19, 2022 •

edited

Loading

webkit-early-warning-system commented Oct 19, 2022 •

edited

Loading

webkit-early-warning-system commented Oct 21, 2022 •

edited

Loading