Skip to content

[FIX][PROPOSAL] Fix case sensitive check of filenames for symbols resolving. #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[FIX][PROPOSAL] Fix case sensitive check of filenames for symbols resolving. #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion LuaDkmDebuggerComponent/LocalComponent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2609,8 +2609,11 @@ DkmResolvedDocument[] IDkmSymbolDocumentCollectionQuery.FindDocuments(DkmModule
}

var fileName = script.Value.resolvedFileName;
var sourceDocumentName = sourceFileId.DocumentName;

if (sourceFileId.DocumentName == fileName)
// Comparing file paths with ignoring case.
// OK for windows, by may be problematic with unix based operating systems.
if (String.Equals(fileName, sourceDocumentName, StringComparison.OrdinalIgnoreCase))
{
var dataItem = new LuaResolvedDocumentItem
{
Expand Down
3 changes: 1 addition & 2 deletions LuaDkmDebuggerComponent/Log.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
using System;
using System.Diagnostics;
using System.IO;

namespace LuaDkmDebuggerComponent
Expand Down Expand Up @@ -51,7 +50,7 @@ protected void Output(string text)
{
try
{
string formatted = $"{text} at {(DateTime.Now.Ticks / 10000.0) - startTime}ms";
string formatted = $"[{(DateTime.Now.Ticks / 10000.0) - startTime}] {text}";

System.Diagnostics.Debug.WriteLine(formatted);

Expand Down