Skip to content

Conversation

summercms
Copy link
Contributor

UA Examples:

User agent Version Popularity
Go-http-client/1.1 1.1 Very common
Go-http-client/2.0 2 Common
Go-http-client/1.1 https://hstspreload.org/ checker; see https://sapphire.alexcohn.com/hsts.html 1.1 Uncommon
Go-http-client/1.1 1.1 Uncommon
Mozilla/5.0 (compatible; Go-http-client/1.1; +aaa@bbb.com) 1.1 Uncommon
go-httpclient v0.5.1 0.5 Uncommon
Go-http-client/1.1 1.1 Uncommon
Go-http-client/1.2 1.2 Uncommon
Go-http-client/1.1 - [handyCafe Filter/3.3.16] 1.1 Uncommon

PR adds two test cases.

Link to this repo tests: http://thadafinser.github.io/UserAgentParserComparison/v5/user-agent-detail/fa/0e/fa0e85a4-0f6f-4c13-b573-9d14c87cc2e2.html#modal-47a9cd06-e213-4882-bc34-db6aed664223

@coveralls
Copy link

coveralls commented Oct 6, 2020

Coverage Status

Coverage increased (+0.02%) to 99.97% when pulling 974f868 on ayumi-cloud:Go-http-client into 880b9fa on WhichBrowser:master.

@summercms
Copy link
Contributor Author

PHP Fatal error: Uncaught Error: Call to a member function toArray() on string in /home/travis/build/WhichBrowser/Parser-PHP/src/Model/Browser.php:168

@summercms
Copy link
Contributor Author

Stuck on this - not sure what the issue is going on? Any suggestions from anyone would be helpful.

@mariotsi
Copy link
Member

mariotsi commented Oct 7, 2020 via email

@summercms
Copy link
Contributor Author

Found the solution now!

@NielsLeenheer
Copy link
Member

Fixed by efffe03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants