-
Notifications
You must be signed in to change notification settings - Fork 16
IW-1483 | Removing LI from search trending, replacing it with top fandom articles #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
13776b3
IW-1483 | Using content-recommendations API for search trending
bkoval ede1b3d
IW-1483 | Crop images to aspect ratio
bkoval f33f69d
IW-1476 | add sponsored content
xkxd 23fa19e
IW-1476 | Tracking for search trending
bkoval 1df0126
IW-1476 | update ember-fandom
xkxd c928093
IW-1476 | Tracking for sponsored item
bkoval a29f843
Merge pull request #320 from Wikia/IW-1476
xkxd 95fad8f
IW-1483 | update lock
xkxd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 changes: 44 additions & 0 deletions
44
app/components/global-navigation/sponsored-content-card.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| import Component from '@ember/component'; | ||
| import { readOnly } from '@ember/object/computed'; | ||
|
|
||
| export default Component.extend({ | ||
| tagName: 'a', | ||
| classNames: ['wds-content-recommendations__card'], | ||
| attributeBindings: ['href'], | ||
| href: readOnly('model.url'), | ||
|
|
||
| click(event) { | ||
| const eventsToTrack = [ | ||
| { | ||
| action: 'click', | ||
| label: 'search' | ||
| }, | ||
| { | ||
| action: 'click', | ||
| label: 'sponsored-item' | ||
| }, | ||
| { | ||
| action: 'select', | ||
| label: this.model.url | ||
| } | ||
| ]; | ||
|
|
||
| const clickedItemSpecificEvent = { | ||
| action: 'click' | ||
| }; | ||
|
|
||
| if (event.target.classList.contains('wds-content-recommendations__card-thumbnail')) { | ||
| clickedItemSpecificEvent.label = 'search-trending-thumbnail'; | ||
| } else { | ||
| clickedItemSpecificEvent.label = 'search-trending-card'; | ||
| } | ||
|
|
||
| this.track && eventsToTrack.forEach(({ action, label }) => { | ||
| this.track({ | ||
| action, | ||
| label, | ||
| category: 'recirculation' | ||
| }); | ||
| }); | ||
| } | ||
| }); |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
app/templates/components/global-navigation/content-recommendations.hbs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
app/templates/components/global-navigation/sponsored-content-card.hbs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| <img | ||
| src={{model.thumbnailUrl}} | ||
| alt={{model.title}} | ||
| class="wds-content-recommendations__card-thumbnail" | ||
| > | ||
|
|
||
| <div class="wds-content-recommendations__card-info"> | ||
| <span class="wds-content-recommendations__card-title"> | ||
| {{model.title}} | ||
| </span> | ||
| {{#if model.attribution}} | ||
| <span class="wds-content-recommendations__card-time"> | ||
| {{model.attributionLabel}} {{model.attribution}} | ||
| </span> | ||
| {{/if}} | ||
| </div> |
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about using
fetchservice from ember-fandom?