Skip to content

CAKE-4662 | 🐛 Add className to countdown components #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 11, 2019
Merged

CAKE-4662 | 🐛 Add className to countdown components #75

merged 2 commits into from
Apr 11, 2019

Conversation

@vforge
Copy link
Collaborator

@vforge vforge commented Apr 8, 2019

No description provided.

@vforge vforge requested a review from JoshuaRogan April 8, 2019 19:59
@JoshuaRogan
Copy link
Contributor

JoshuaRogan commented Apr 9, 2019

Why do we need this?

@vforge
Copy link
Collaborator Author

vforge commented Apr 9, 2019 •
edited
Loading

@JoshuaRogan We cannot styled(StyledAvatar) without it. Because StyledAvatar doesn't accept className prop right now:

It looks like you've wrapped styled() around your React component (StyledAvatar), but the className prop is not being passed down to a child. No styles will be rendered unless className is composed within your React component.

@vforge
Copy link
Collaborator Author

vforge commented Apr 9, 2019

Or actually we should export styled(Component).

@vforge vforge merged commit 1d64c44 into master Apr 11, 2019
@vforge vforge deleted the classname-for-countdown branch April 11, 2019 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JoshuaRogan JoshuaRogan JoshuaRogan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vforge @JoshuaRogan