Skip to content
This repository was archived by the owner on Jan 21, 2019. It is now read-only.

Conversation

cschucode
Copy link

No description provided.

@cschucode cschucode requested a review from vforge as a code owner June 25, 2018 20:41
@coveralls
Copy link

Pull Request Test Coverage Report for Build 238

  • 14 of 86 (16.28%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-26.8%) to 73.228%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/GlobalNavigation/components/User.js 3 7 42.86%
src/components/GlobalNavigation/components/UserAnon.js 3 7 42.86%
src/components/GlobalNavigation/components/Search.js 2 20 10.0%
src/components/GlobalNavigation/index.js 2 24 8.33%
src/components/GlobalNavigation/components/Link.js 2 26 7.69%
Totals Coverage Status
Change from base Build 231: -26.8%
Covered Lines: 190
Relevant Lines: 262

💛 - Coveralls

@vforge vforge changed the base branch from master to FAN-3742 June 25, 2018 20:47

@media #{$wds-breakpoint-l-up} {
padding-right: 42px;
@media #{$wds-breakpoint-large-up} {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that needed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed the media query and applied to all breakpoints. to align right

@vforge vforge merged commit 31388bd into FAN-3742 Jun 25, 2018
@vforge vforge deleted the FAN-3742-edition-styles branch June 25, 2018 23:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants