Skip to content
This repository was archived by the owner on Jan 21, 2019. It is now read-only.

Conversation

vforge
Copy link
Collaborator

@vforge vforge commented Jun 26, 2018

No description provided.

Copy link

@cschucode cschucode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. All tests passed, but I was curious about the performance metric colors?
Global Footer --> yellow
Global Nav --> red
Is there a way to improve?

@cschucode cschucode merged commit 44ce2af into FAN-3742 Jun 27, 2018
@cschucode
Copy link

Also getting a warning for unique key prop in GlobalNavigation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants