Skip to content

add --benchtime argument #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2020
Merged

add --benchtime argument #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,13 @@ Flags:
--base-ref="HEAD" The git ref to be used as a baseline.
--bench="." Run only those benchmarks matching a regular
expression.
--bench-args="test -bench {{.Bench}} -run '^$' -benchmem -count {{.BenchCount}} {{.Packages}}"
--bench-args="test -bench {{.Bench}} -run '^$' -benchtime {{.Benchtime}} -benchmem -count {{.BenchCount}} {{.Packages}}"
Use these arguments to run benchmarks. It may
be a template.
--bench-cmd="go" The go command to use for benchmarks.
--bench-count=10 Run each benchmark n times.
--benchtime="1s" The -benchtime argument for the go test
command
--cache-dir="./tmp" The directory where benchmark output will
kept between runs.
--force-base Rerun benchmarks on the base reference even
Expand Down
4 changes: 3 additions & 1 deletion cmd/benchdiff/benchdiff.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import (
"golang.org/x/perf/benchstat"
)

const defaultBenchArgsTmpl = `test -bench {{.Bench}} -run '^$' -benchmem -count {{.BenchCount}} {{.Packages}}`
const defaultBenchArgsTmpl = `test -bench {{.Bench}} -run '^$' -benchtime {{.Benchtime}} -benchmem -count {{.BenchCount}} {{.Packages}}`

var benchstatVars = kong.Vars{
"AlphaDefault": "0.05",
Expand Down Expand Up @@ -54,6 +54,7 @@ var benchVars = kong.Vars{
"BenchCountHelp": `Run each benchmark n times.`,
"BenchHelp": `Run only those benchmarks matching a regular expression.`,
"BenchArgsHelp": `Use these arguments to run benchmarks. It may be a template.`,
"BenchtimeHelp": `The -benchtime argument for the go test command`,
"PackagesHelp": `Run benchmarks in these packages.`,
"BenchCmdHelp": `The go command to use for benchmarks.`,
"CacheDirHelp": `The directory where benchmark output will kept between runs.`,
Expand All @@ -71,6 +72,7 @@ var cli struct {
BenchArgs string `kong:"default=${BenchArgsDefault},help=${BenchArgsHelp}"`
BenchCmd string `kong:"default=${BenchCmdDefault},help=${BenchCmdHelp}"`
BenchCount int `kong:"default=10,help=${BenchCountHelp}"`
Benchtime string `kong:"default='1s',help=${BenchtimeHelp}"`
CacheDir string `kong:"type=dir,default=${CacheDirDefault},help=${CacheDirHelp}"`
ForceBase bool `kong:"help=${ForceBaseHelp}"`
GitCmd string `kong:"default=git,help=${GitCmdHelp}"`
Expand Down