Merged
Conversation
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
There was a problem hiding this comment.
Code Review
This pull request reorganizes the package.json structure and moves monaco-editor from peerDependencies and devDependencies to a direct dependency. A review comment highlights that pinning monaco-editor to an exact version in dependencies is risky for a library, as it can cause version conflicts and runtime errors in consumer projects, and suggests using a version range instead.
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
monaco-editorfrom peer/dev dependency to an exact runtime dependency so consumers do not need to install it separately for type resolution.reactandreact-domas app-owned peer dependencies.@willbooster/monaco-loaderto the published1.1.1release.tsuptobuild-ts@17.1.5and remove the obsoletetsupconfig.wbfygenerated maintenance updates.Why
@willbooster/monaco-reactwithout separately choosing a compatiblemonaco-editorversion.monaco-editormust be available for consumer TypeScript resolution.monaco-editorexactly keeps the declarations, wrapper code, and loader default Monaco version aligned.@willbooster/monaco-loader@1.1.1carries the matching loader-side dependency metadata change.build-ts@17.1.5supports this package shape: a TypeScript entry that re-exports TSX modules, preserved root output files, external declared dependencies, and bundler module resolution for declarations.Testing
yarn start /Users/exkazuu/ghq/github.com/WillBooster/monaco-reactfrom~/ghq/github.com/WillBooster/shared/packages/wbfyyarn builddist/index.js,dist/index.cjs, anddist/index.d.tsexist.dist/srcordist/node_modules.@willbooster/monaco-loaderas a package dependency.node -e "const m=require('./dist/index.cjs'); ..."node --input-type=module -e "const m=await import('./dist/index.js'); ..."yarn check-for-aipassed with 9 existing warnings and 0 errors.checkpassed with the same 9 existing warnings and 0 errors.