fix: complete monaco dependency build migration#9
Merged
Conversation
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
There was a problem hiding this comment.
Code Review
This pull request transitions monaco-editor from a peer dependency to a direct dependency and replaces the tsup build system with build-ts. It also adds the 'use client'; directive to the main entry point for React Server Components compatibility. Feedback was provided regarding the phrasing of dependency ownership in the README and a potential versioning error concerning Next.js.
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
…r' into fix/complete-monaco-dependency-pr
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
…r' into fix/complete-monaco-dependency-pr
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
…r' into fix/complete-monaco-dependency-pr
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
…r' into fix/complete-monaco-dependency-pr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #6.
Summary
tsuptobuild-ts liband remove the obsoletetsupconfig.use clientdirective so the minifiedbuild-tsoutput preserves the client-component marker that the oldtsupbanner injected.monaco-editoris now installed with this package instead of required as a peer install.distentry, and type-checks against generated declarations whendistexists.yarn test:e2e:next, where the Next fixture needs the generateddistpackage surface.typescriptdev dependency and rely on@typescript/native-preview/tsgofor project type checking.distartifacts exist.build/corescript foryarn buildso CI does not depend on a globalwbbinary.Why
monaco-editorinto runtime dependencies, but the merged branch still usedtsupeven though the PR body described thebuild-tsmigration.distfiles or globally installed WillBooster tooling.Testing
yarn typecheckyarn buildyarn lintyarn check-for-aiyarn test:e2e:nextgit diff --checkdistoutside the repository and runningyarn lint.dist/index.jsanddist/index.cjsstill start with"use client".dist/index.js,dist/index.cjs, anddist/index.d.tsexist.dist/srcordist/node_modules.node -e "const m=require('./dist/index.cjs'); console.log(typeof m.default, typeof m.Editor, typeof m.DiffEditor, typeof m.loader, typeof m.useMonaco)"node --input-type=module -e "const m=await import('./dist/index.js'); console.log(typeof m.default, typeof m.Editor, typeof m.DiffEditor, typeof m.loader, typeof m.useMonaco)"checkpassed with 0 warnings and 0 errors.Notes
next build e2e/next-appprints a warning that some Next.js TypeScript features require the standardtypescriptpackage because it detects@typescript/native-preview; the build and Playwright e2e still pass.