Skip to content

fix: include framework TypeScript scripts in tsconfig#747

Merged
exKAZUu merged 6 commits intomainfrom
fix/next-script-tsconfig
May 4, 2026
Merged

fix: include framework TypeScript scripts in tsconfig#747
exKAZUu merged 6 commits intomainfrom
fix/next-script-tsconfig

Conversation

@exKAZUu
Copy link
Copy Markdown
Member

@exKAZUu exKAZUu commented May 4, 2026

Summary

  • Update wbfy Next/Blitz tsconfig cleanup to always include scripts/**/* in the existing framework-owned tsconfig.json.
  • Preserve the rest of the framework tsconfig shape instead of applying the generic generated tsconfig or creating a nested script config.
  • Avoid type-aware global scope collisions by giving the generated CommonJS oxfmt.config.ts a unique resolved config variable name.
  • Add generator coverage for adding scripts/**/* and avoiding duplicate includes.

Verification

  • yarn vitest test/tsconfigGenerator.test.ts from packages/wbfy
  • yarn verify
  • Applied local wbfy to WillBoosterLab/exercode and WillBoosterLab/survey-system, then ran yarn verify in both target repos

Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces logic to automatically include the scripts/**/* pattern in tsconfig.json for framework projects that contain TypeScript files within their scripts directory. Feedback was provided to ensure the code adheres to the repository's top-down function ordering style, to simplify the implementation by reusing existing utility functions, and to optimize performance by checking if the project contains TypeScript before executing a file system glob.

Comment thread packages/wbfy/src/generators/tsconfig.ts Outdated
exKAZUu and others added 5 commits May 4, 2026 14:39
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
@exKAZUu exKAZUu merged commit 997d8aa into main May 4, 2026
6 checks passed
@exKAZUu exKAZUu deleted the fix/next-script-tsconfig branch May 4, 2026 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant