fix: include framework TypeScript scripts in tsconfig#747
Merged
Conversation
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces logic to automatically include the scripts/**/* pattern in tsconfig.json for framework projects that contain TypeScript files within their scripts directory. Feedback was provided to ensure the code adheres to the repository's top-down function ordering style, to simplify the implementation by reusing existing utility functions, and to optimize performance by checking if the project contains TypeScript before executing a file system glob.
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/**/*in the existing framework-ownedtsconfig.json.oxfmt.config.tsa unique resolved config variable name.scripts/**/*and avoiding duplicate includes.Verification
yarn vitest test/tsconfigGenerator.test.tsfrompackages/wbfyyarn verifyyarn verifyin both target repos