Skip to content

Sensor registry defaults for single vs. three phase #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WillCodeForCats merged 4 commits into from
Sep 22, 2022
Merged

Sensor registry defaults for single vs. three phase #93

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
efaf82c
Set enable default on single vs. three phase
WillCodeForCats Sep 17, 2022
039dcea
Update sensor.py
WillCodeForCats Sep 17, 2022
c2323af
Set defaults for AC Power and Energy classes
WillCodeForCats Sep 17, 2022
7c3c80a
Missed A phase on meter check
WillCodeForCats Sep 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 85 additions & 0 deletions custom_components/solaredge_modbus_multi/sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,6 +552,25 @@ def unique_id(self) -> str:
else:
return f"{self._platform.uid_base}_ac_current_{self._phase.lower()}"

@property
def entity_registry_enabled_default(self) -> bool:
if self._phase is None:
return True

elif self._platform.decoded_model["C_SunSpec_DID"] in [
103,
203,
204,
] and self._phase in [
"A",
"B",
"C",
]:
return True

else:
return False

@property
def name(self) -> str:
if self._phase is None:
Expand Down Expand Up @@ -615,6 +634,30 @@ def unique_id(self) -> str:
else:
return f"{self._platform.uid_base}_ac_voltage_{self._phase.lower()}"

@property
def entity_registry_enabled_default(self) -> bool:
if self._phase is None:
raise NotImplementedError

elif self._phase in ["LN", "LL", "AB"]:
return True

elif self._platform.decoded_model["C_SunSpec_DID"] in [
103,
203,
204,
] and self._phase in [
"BC",
"CA",
"AN",
"BN",
"CN",
]:
return True

else:
return False

@property
def name(self) -> str:
if self._phase is None:
Expand Down Expand Up @@ -670,6 +713,24 @@ def unique_id(self) -> str:
else:
return f"{self._platform.uid_base}_ac_power_{self._phase.lower()}"

@property
def entity_registry_enabled_default(self) -> bool:
if self._phase is None:
return True

elif self._platform.decoded_model["C_SunSpec_DID"] in [
203,
204,
] and self._phase in [
"A",
"B",
"C",
]:
return True

else:
return False

@property
def name(self) -> str:
if self._phase is None:
Expand Down Expand Up @@ -950,6 +1011,30 @@ def unique_id(self) -> str:
else:
return f"{self._platform.uid_base}_{self._phase.lower()}_kwh"

@property
def entity_registry_enabled_default(self) -> bool:
if self._phase is None or self._phase in [
"Exported",
"Imported",
"Exported_A",
"Imported_A",
]:
return True

elif self._platform.decoded_model["C_SunSpec_DID"] in [
203,
204,
] and self._phase in [
"Exported_B",
"Exported_C",
"Imported_B",
"Imported_C",
]:
return True

else:
return False

@property
def name(self) -> str:
if self._phase is None:
Expand Down