[issueid # JAV-34] cse starter to support service discovery using zuu… #3
Conversation
…l/EnableAutoDiscovery Signed-off-by: sukesh a c <sukeshac@huawei.com>
| <groupId>org.springframework.cloud</groupId> | ||
| <artifactId>spring-cloud-context</artifactId> | ||
| </dependency> | ||
| <groupId>org.springframework.cloud</groupId> |
| <groupId>com.huawei.paas.cse</groupId> | ||
| <artifactId>cse-adapter-springmvc</artifactId> | ||
| </dependency> | ||
| <groupId>com.netflix.ribbon</groupId> |
| * @author Sukesh | ||
| */ | ||
| @Configuration | ||
| @EnableConfigurationProperties |
There was a problem hiding this comment.
why EnableConfigurationProperties here?
| String serviceName = config.getClientName(); | ||
| String appID = cseRoutesProperties.getAppID(); | ||
| String versionRule = cseRoutesProperties.getVersionRule(serviceName); | ||
| CseServerListWrapper serverList = new CseServerListWrapper(appID, serviceName, versionRule, "rest"); |
| @Autowired | ||
| private ZuulProperties zuulProperties; | ||
|
|
||
| private Map<String, String> appServiceMap = null; |
| public ServiceRouteMapper cseServiceRouteMapper() { | ||
| return new CseServiceRouteMapper(); | ||
| @Bean | ||
| @ConditionalOnMissingBean |
There was a problem hiding this comment.
why does ConditionalOnMissingBean have no bean class provided?
| <dependency> | ||
| <groupId>org.springframework.cloud</groupId> | ||
| <artifactId>spring-cloud-starter-zuul</artifactId> | ||
| <version>1.3.0.RELEASE</version> |
There was a problem hiding this comment.
can we use a single spring cloud parent instead of managing all the versions ourselves?
There was a problem hiding this comment.
once the versions base lined, will optimize all the version configurations
| <dependency> | ||
| <groupId>com.netflix.ribbon</groupId> | ||
| <artifactId>ribbon-loadbalancer</artifactId> | ||
| <version>2.2.2</version> |
There was a problem hiding this comment.
the versions can be managed in parent
There was a problem hiding this comment.
once the versions base lined, will optimize all the version configurations
| <logback.version>1.1.7</logback.version> | ||
| <spring-cloud-commons.version>1.2.0.RELEASE</spring-cloud-commons.version> | ||
| <spring-cloud-netflix.version>1.3.0.RELEASE</spring-cloud-netflix.version> | ||
| <spring-cloud-commons.version>1.1.0.RELEASE</spring-cloud-commons.version> |
There was a problem hiding this comment.
we shall use a spring cloud parent to manage the dependencies, or we may have version conflicts
There was a problem hiding this comment.
once the versions base lined, will optimize all the version configurations
|
|
||
| //TODO to load when webapplication context is used for discovery client, need to check if can use the order and undo this change with proper fix. | ||
| if(!isInit) | ||
| { |
…l/EnableAutoDiscovery Signed-off-by: sukesh a c <sukeshac@huawei.com>
|
Changes Unknown when pulling 305429e on acsukesh:master into ** on WillemJiang:master**. |
…l/EnableAutoDiscovery && meregr from master Signed-off-by: sukesh a c <sukeshac@huawei.com>
3 participants
…l/EnableAutoDiscovery
Signed-off-by: sukesh a c sukeshac@huawei.com