Log and CLI #16
Merged
Log and CLI #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @brettviren for making this update. I tested it with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up two inter-related things: logging and the creation of the Click "group" object.
It provides a Python decorator for creating the Click
clifunction so that everywirecell-*command gets common command line options (for logging and help). It applies this to all the current__main__.py.With this in place, all
__main__.pyand module code may use, eg,log.debug()instead ofprint(). This PR replacesprint()withlogmethods in the__main__.pybut there are still manyprint()sprinkled in the modules.It also moves the some other Click-related decorators from
plots.clitoutil.cliand applies them to a few new commands.Breaking: These new applications do change the command line option flags for some of the sub-commands. I figure having standardized calling patterns is worth the breakage. It's why I make this a PR instead of just pushing.
There are still more functions with nearly common option patterns and it would be good to further standardize. But, first let's see what problems (if any) this breaking change causes.