Use ava for tests and Stylelint 4.x

[ntwb]

No description provided.

[TrySound]

Don't need to catch this. Just return promise.

[jeddy3]

@TrySound Do you mean like this?:

test("no warnings with valid css", t => {
  return stylelint.lint({
    code: validCss,
    config: config,
  })
  .then(data => {
    const { errored, results } = data
    const { warnings } = results[0]
    t.notOk(errored, "no errored")
    t.is(warnings.length, 0, "flags no warnings")
  })
})

I just want to double check before I update the tests in the standard and suitcss configs as well.

[TrySound]

yep

[jeddy3]

@TrySound Thanks! :)

@ntwb Are you able to update the tests in this PR if I go ahead and update standard and suitcss?

[TrySound]

Here too

[ntwb]

Thanks for the feedback and code tweaks @TrySound & @jeddy3

Apologies for not getting to this sooner 😄

[TrySound]

There is 0.11.0 already. Update before merge please :)

[ntwb]

Done, thanks 👍

[ntwb]

I cannot work out why the Windows AppVeyor tests fail for NodeJS v5.x ¯_(ツ)_/¯

[jeddy3]

Can you try adding these tweaks to your appveyor file please?

I'm not sure what you think, but perhaps testing on .12, 4 and 5 is a little excessive for a config. Probably just 5 is alright?

[ntwb]

I removed the node-modules folder from the AppVeyor cache and:

WordPress' currently supports "build tools" on each of these NodeJS versions, as such I'd like to try and keep compatibility of all these NodeJS versions for both *nix and Windows.

[TrySound]

Yeah cache invalidating is the worst thing ever :)

[ntwb]

The AppVeyor 5.x build failed again, I've restarted some builds and jobs as comparing AVA 0.11.0 AppVeyor builds I've a suspicion this could actually be an AppVeyor issue rather than ours!

[jeddy3]

as such I'd like to try and keep compatibility of all these NodeJS versions for both *nix and Windows.

Sgtm.

I've a suspicion this could actually be an AppVeyor issue rather than ours!

Agreed. Previously version 4 failed and 5 passed. I restarted the test a few minutes ago and 4 now passes, but 5 fails :(

[ntwb]

Agreed, will merge now, maybe after merging AppVeyor will settle down ¯_(ツ)_/¯

[ntwb]

Each of the 5.x, 4.x, and 0.12.x AppVeyor builds now pass 👍

https://ci.appveyor.com/project/stylelint/stylelint-config-wordpress/build/98