-
Couldn't load subscription status.
- Fork 32
chore: php remediations #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
29dc92f to
c97f8bf
Compare
c97f8bf to
d4af415
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Co-authored-by: Dovid Levine <justlevine@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a nice improvement. We can address the rest of reported issues in follow-up PRs. I like how it helps to catch some small things in the code 💯
This was an actual error that I fixed in f762155. |
What
This is a first pass of PHPStan/PHPCS remediations. Most were auto-fixed, a couple (like moving the file headers above the
declare_strict()),Some tweaks to the
phpcs.xml.distas well, due to some accidental conflicts when I was deduping rulesets.Follow up to #4
Remaining smells are:
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedFunctionFound- do we want a namespace?WordPress.WP.I18n.MissingArgDomain- do we want this translatable before merged into core?And then some things that need actual remediation (using
WP_Abilityas a string) or a decision about if we want to suppress/fix/turn off the rule.Why