Skip to content

Conversation

desrosj
Copy link
Member

@desrosj desrosj commented Aug 26, 2025

This introduces the setup_runner_env_vars() function, which processes all runner-related environment variables that are used in multiple scripts (prepare.php, test.php, etc.).

There are also some new default values being added for when certain environment variables are missing entirely. These new default values were initially added in #212, but they are being split out for separate consideration. This PR expands on the commit that introduced defaults a bit by also refining the expected/actual data types.

Other notes:

  • WPT_DEBUG has changed from expecting a falsey value or verbose to expecting a falsey or truthy value. This should preserve the current behavior while making it more closely match Core, and be easier to understand as an on/off switch.
  • WPT_CERTIFICATE_VALIDATION will now default to true when not set at all. This guards against a misconfiguration accidentally leaving the script potentially vulnerable.
  • The processing of WPT_SSH_PRIVATE_KEY_BASE64 was left out of the function to avoid unintentionally exposing the value in the test, report, or cleanup scripts.

desrosj and others added 7 commits August 25, 2025 20:12
This introduces `setup_runner_env_vars()` to process environment variables used to configure the test runner to avoid repeated code.
This switches to handling debug mode as a boolean matching truthy values, which simplifies things.
Co-Authored-By: Javier Casares <javier@casares.org>
When this is not defined at all, assume a misconfiguration and verify certificates.
@desrosj desrosj self-assigned this Aug 26, 2025
Copy link

github-actions bot commented Aug 26, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>
Co-authored-by: kittenkamala <amykamala@git.wordpress.org>
Co-authored-by: Crixu <crixu@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj desrosj merged commit 19e3068 into master Sep 8, 2025
3 checks passed
@desrosj desrosj deleted the reduce-repitition branch September 8, 2025 13:02
desrosj added a commit that referenced this pull request Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants