Skip to content

Remove unused WPT_CERTIFICATE_VALIDATION environment variable #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kittenkamala merged 1 commit into from
Oct 1, 2025
Merged

Remove unused WPT_CERTIFICATE_VALIDATION environment variable #282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions functions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ function check_required_env( $check_db = true ) {
* inner blocks were found.
* @type string $WPT_RM_TEST_DIR_CMD Command for removing the test directory.
* @type string $WPT_REPORT_API_KEY API key for submitting test results.
* @type bool $WPT_CERTIFICATE_VALIDATION Whether to validate TLS certificates. Default true.
* @type bool $WPT_DEBUG_MODE Whether debug mode is enabled.
* }
* }
Expand All @@ -74,15 +73,7 @@ function setup_runner_env_vars() {
'WPT_TEST_DIR' => trim( getenv( 'WPT_TEST_DIR' ) ) ?: '/tmp/wp-test-runner',
);

/*
* When no value is provided for WPT_CERTIFICATE_VALIDATION, assume that the default of true (validate certificates)
* is desired.
*/
if ( false === getenv( 'WPT_CERTIFICATE_VALIDATION' ) ) {
$runner_configuration['WPT_CERTIFICATE_VALIDATION'] = true;
} else {
$runner_configuration['WPT_CERTIFICATE_VALIDATION'] = (bool) getenv( 'WPT_CERTIFICATE_VALIDATION' );
}


return array_merge(
$runner_configuration,
Expand Down
8 changes: 0 additions & 8 deletions prepare.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,14 +68,6 @@

}

/**
* Don't validate the TLS certificate
* Useful for local environments
*/
$certificate_validation = '';
if( ! $runner_vars['WPT_CERTIFICATE_VALIDATION'] ) {
$certificate_validation .= ' --no-check-certificate';
}

/**
* Performs a series of operations to set up the test environment. This includes creating a preparation directory,
Expand Down