Bugfix: ensure the update post type ability doesn't create new posts instead #239
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes the update post ability to require the ID, preventing the creation of new posts instead.
Why
Previously, the ability required either an ID, a key, or a slug. However, the internal
acf_update_post_typecreates a new post if not provided with the ID it needs to update, so updates could result in new posts.How
register_update_post_type_ability()to useget_post_type_with_internal_fields_schema()with onlyIDmarked as required, making all other fields optional.update_post_type_callback()to merge incoming input with existing post type data, ensuring that only specified fields are updated while preserving original values for the rest.