Skip to content

Ingore FOREIGN KEY constraint definitions #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JanJakes wants to merge 1 commit into from
Closed

Ingore FOREIGN KEY constraint definitions #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions tests/WP_SQLite_Driver_Tests.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6581,4 +6581,24 @@ public function testRollbackNonExistentTransactionSavepoint(): void {
$this->expectExceptionMessage( 'no such savepoint: sp1' );
$this->assertQuery( 'ROLLBACK TO SAVEPOINT sp1' );
}

public function testForeignKeyConstraintAreIgnored(): void {
/*
* FOREIGN KEY constraints are not supported yet, they will be ignored.
* The following query will work, although it references a missing table.
*/
$this->assertQuery( 'CREATE TABLE t (id INT, CONSTRAINT c FOREIGN KEY (id) REFERENCES tt (id))' );
$result = $this->assertQuery( 'SHOW CREATE TABLE t' );
$this->assertEquals(
implode(
"\n",
array(
'CREATE TABLE `t` (',
' `id` int DEFAULT NULL',
') ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_0900_ai_ci',
)
),
$result[0]->{'Create Table'}
);
}
}
13 changes: 7 additions & 6 deletions wp-includes/sqlite-ast/class-wp-sqlite-information-schema-builder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1100,12 +1100,13 @@ private function record_add_constraint(
$keyword = $keyword->get_first_child_token();
}

// FOREIGN KEY and CHECK constraints are not supported yet.
if (
WP_MySQL_Lexer::FOREIGN_SYMBOL === $keyword->id
|| WP_MySQL_Lexer::CHECK_SYMBOL === $keyword->id
) {
throw new \Exception( 'FOREIGN KEY and CHECK constraints are not supported yet.' );
// FOREIGN KEY constraints are not supported yet; they will be ignored.
// @TODO: Implement support for FOREIGN KEY constraints.

// CHECK constraints are not supported yet.
// @TODO: Implement support for CHECK constraints.
if ( WP_MySQL_Lexer::CHECK_SYMBOL === $keyword->id ) {
throw new \Exception( 'CHECK constraints are not supported yet.' );
}

// PRIMARY KEY and UNIQUE require an index.
Expand Down
Loading