Fixes for phpMyAdmin, Adminer, etc. #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanJakes
force-pushed
the
phpmyadmin-fixes
branch
from
db3e1f1 to
821a8ce
Compare
JanJakes
commented
Oct 16, 2025
| ('utf8mb4_bin', 'utf8mb4', 46, '', 'Yes', 1, 'PAD SPACE'), | ||
| ('utf8mb4_unicode_ci', 'utf8mb4', 224, '', 'Yes', 8, 'PAD SPACE'), | ||
| ('utf8mb4_0900_ai_ci', 'utf8mb4', 255, 'Yes', 'Yes', 0, 'NO PAD') | ||
| )"; |
There was a problem hiding this comment.
This was a "quick fix", but it's actually quite nice—the tables are not materialized until requested.
Maybe in the future, we can unify it to real tables, but I suppose there's no urgency at the moment, as this seems to be working fine.
There was a problem hiding this comment.
Yeah this is a very nice direction. This information is dynamic in nature, storing it would be quite inconvenient since we'd need to migrate existing databases whenever something changes. Lovely.
adamziel
reviewed
Oct 16, 2025
| string $database, | ||
| int $mysql_version = 80038 | ||
| ) { | ||
| $this->mysql_version = $mysql_version; |
adamziel
reviewed
Oct 16, 2025
| return 'REAL'; | ||
| default: | ||
| throw $this->new_not_supported_exception( | ||
| sprintf( 'cast type: %s', $first_child->get_value() ) |
adamziel
reviewed
Oct 16, 2025
| ) { | ||
| $table_name = strtolower( $table_name ); | ||
|
|
||
| // Some information schema tables can be computed on the fly. |
There was a problem hiding this comment.
This is really nice and I bet this is also how MySQL does it.
adamziel
approved these changes
Oct 16, 2025
|
Very nice 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a set of fixes of issues discovered when testing phpMyAdmin and Adminer:
USEstatement when switching back to the main database (USE wp).@@versionand@@version_commentsystem variables.INFORMATION_SCHEMA.CHARACTER_SETS.INFORMATION_SCHEMA.COLLATIONS.SHOW COLLATIONSstatement.CASTexpression handling.There are more fixes to come, but maybe we can add those in subsequent PRs so that the scope here doesn't explode.