MySQL proxy improvements #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanJakes
force-pushed
the
mysql-proxy-improvements
branch
3 times, most recently
from
614a278 to
15b3f35
Compare
JanJakes
force-pushed
the
mysql-proxy-improvements
branch
from
3200817 to
bb046b4
Compare
JanJakes
force-pushed
the
mysql-proxy-improvements
branch
from
bb046b4 to
41612c1
Compare
adamziel
reviewed
Nov 20, 2025
| * @return string The decoded string value. | ||
| */ | ||
| public static function read_null_terminated_string( string $payload, int &$offset ): string { | ||
| $value = unpack( 'Z*', $payload, $offset )[1]; |
Collaborator
There was a problem hiding this comment.
should we check all unpack calls for false return value ?
Collaborator
There was a problem hiding this comment.
This PR Already adds value as it is so I'll go ahead and merge. Let's iterate on the improvements in a follow-up.
adamziel
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR further improves and refactors the original MySQL proxy prototype. Notably:
pack()andunpack()when possible.MySQL_Protocol::CLIENT_CONNECT_WITH_DBcapability).MySQL_Protocol::CLIENT_DEPRECATE_EOFcapability.I've tried the proxy with the following tools, which are working now:
I think this is a good point to stop at for this PR. The refactor may go further, and there are more things to implement (prepared statements for
mysqli, full authentication support, and more), but I'd leave those to separate issues.I'm also considering moving the packet building methods from
MySQL_ProtocoltoMySQL_Session, as currently, these need to pass many function parameters in some cases, while in theMySQL_Sessionclass, private state properties could be used directly for some attributes.