-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Refactor wp_admin_bar_my_account_item function
#10109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor wp_admin_bar_my_account_item function
#10109
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| $current_user = wp_get_current_user(); | ||
|
|
||
| /* translators: %s: Current user's display name. */ | ||
| $howdy = sprintf( __( 'Howdy, %s' ), '<span class="display-name">' . $current_user->display_name . '</span>' ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the $current_user is only used once, I'll update as follows in commit:
| $current_user = wp_get_current_user(); | |
| /* translators: %s: Current user's display name. */ | |
| $howdy = sprintf( __( 'Howdy, %s' ), '<span class="display-name">' . $current_user->display_name . '</span>' ); | |
| /* translators: %s: Current user's display name. */ | |
| $howdy = sprintf( __( 'Howdy, %s' ), '<span class="display-name">' . wp_get_current_user()->display_name . '</span>' ); |
Trac ticket: https://core.trac.wordpress.org/ticket/64060
wp_get_current_user()closer to where it's needed, improving code clarity and reducing unnecessary variable usage.menu_titleis properly stripped of HTML tags for accessibility and security.This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.
Commit message
Toolbar: Improve conciseness of
wp_admin_bar_my_account_item().Props mukesh27.
Fixes #64060.