Skip to content

Fix sanitization of non-breaking hyphens in sanitize_title_with_dashes #10204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Fix sanitization of non-breaking hyphens in sanitize_title_with_dashes #10204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f51b8ec
Fix sanitization of non-breaking hyphens in sanitize_title_with_dashes
ppiwo Oct 9, 2025
b6c307f
Sanitize non-breaking hypen HTML entity code in sanitize_title_with_d…
ppiwo Oct 22, 2025
4a8e4bf
Add test cases for #64089
ppiwo Oct 22, 2025
f4f149c
Merge branch 'trunk' into ppiwo/trunk
westonruter Oct 22, 2025
7c2fa71
Tidy up test
westonruter Oct 22, 2025
ff2d2a7
Refactor replacement of dashes to hyphens
westonruter Oct 23, 2025
7c52413
Revert "Refactor replacement of dashes to hyphens"
westonruter Oct 25, 2025
c32a470
Merge branch 'trunk' of https://github.com/WordPress/wordpress-develo…
westonruter Oct 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/wp-includes/formatting.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2294,10 +2294,10 @@ function sanitize_title_with_dashes( $title, $raw_title = '', $context = 'displa
$title = strtolower( $title );

if ( 'save' === $context ) {
// Convert &nbsp, &ndash, and &mdash to hyphens.
$title = str_replace( array( '%c2%a0', '%e2%80%93', '%e2%80%94' ), '-', $title );
// Convert &nbsp, &ndash, and &mdash HTML entities to hyphens.
$title = str_replace( array( ' ', ' ', '–', '–', '—', '—' ), '-', $title );
// Convert &nbsp, non-breaking hyphen, &ndash, and &mdash to hyphens.
$title = str_replace( array( '%c2%a0', '%e2%80%91', '%e2%80%93', '%e2%80%94' ), '-', $title );
// Convert &nbsp, non-breaking hyphen, &ndash, and &mdash HTML entities to hyphens.
$title = str_replace( array( ' ', '‑', ' ', '–', '–', '—', '—' ), '-', $title );
// Convert forward slash to hyphen.
$title = str_replace( '/', '-', $title );

Expand Down
14 changes: 14 additions & 0 deletions tests/phpunit/tests/formatting/sanitizeTitleWithDashes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,20 @@ public function test_replaces_ndash_mdash_entities() {
$this->assertSame( 'do-the-dash', sanitize_title_with_dashes( 'Do — the — Dash', '', 'save' ) );
}

/**
* @ticket 64089
*/
public function test_replaces_non_breaking_hyphen() {
$this->assertSame( 'do-the-dash', sanitize_title_with_dashes( 'Do‑the Dash', '', 'save' ) );
}

/**
* @ticket 64089
*/
public function test_replaces_non_breaking_hyphen_entity() {
$this->assertSame( 'do-the-dash', sanitize_title_with_dashes( 'Do ‑ the Dash', '', 'save' ) );
}

public function test_replaces_iexcel_iquest() {
$this->assertSame( 'just-a-slug', sanitize_title_with_dashes( 'Just ¡a Slug', '', 'save' ) );
$this->assertSame( 'just-a-slug', sanitize_title_with_dashes( 'Just a Slug¿', '', 'save' ) );
Expand Down
Loading