Skip to content

Never show notes on the comments page #10462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Never show notes on the comments page #10462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2e3574c
Never show notes on the comments page
adamsilverstein Nov 4, 2025
eb019e4
Move note exclusion logic to comments list table class
adamsilverstein Nov 4, 2025
d2b23a7
Update class-wp-comments-list-table.php
adamsilverstein Nov 4, 2025
868ef26
whitespace
adamsilverstein Nov 7, 2025
631bd56
Add a test to verify that the comments table never shows the note com…
adamsilverstein Nov 7, 2025
66e21b3
phpcbf
adamsilverstein Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/wp-admin/includes/class-wp-comments-list-table.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,11 @@ public function prepare_items() {
$comment_status = 'all';
}

$comment_type = ! empty( $_REQUEST['comment_type'] ) ? $_REQUEST['comment_type'] : '';
$comment_type = '';

if ( ! empty( $_REQUEST['comment_type'] ) && 'note' !== $_REQUEST['comment_type'] ) {
$comment_type = $_REQUEST['comment_type'];
}

$search = ( isset( $_REQUEST['s'] ) ) ? $_REQUEST['s'] : '';

Expand Down
31 changes: 31 additions & 0 deletions tests/phpunit/tests/admin/wpCommentsListTable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,4 +213,35 @@ public function test_get_views_should_return_views_by_default() {
);
$this->assertSame( $expected, $this->table->get_views() );
}

/**
* Verify that the comments table never shows the note comment_type.
*
* @ticket 64198
*/
public function test_comments_list_table_does_not_show_note_comment_type() {
$post_id = self::factory()->post->create();
$note_id = self::factory()->comment->create(
array(
'comment_post_ID' => $post_id,
'comment_content' => 'This is a note.',
'comment_type' => 'note',
'comment_approved' => '1',
)
);
$comment_id = self::factory()->comment->create(
array(
'comment_post_ID' => $post_id,
'comment_content' => 'This is a regular comment.',
'comment_type' => '',
'comment_approved' => '1',
)
);
// Request the note comment type.
$_REQUEST['comment_type'] = 'note';
$this->table->prepare_items();
$items = $this->table->items;
$this->assertCount( 1, $items );
$this->assertEquals( $comment_id, $items[0]->comment_ID );
}
}
Loading