Tests: Fix failing malformed date test #10479
Conversation
t-hamano
changed the title
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
changed the title
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
t-hamano
force-pushed
the
26798-fix-unit-test
branch
from
438380c to
425d63d
Compare
|
If this regular expression is truly correct, then months and days with leading zeros missing should be acceptable. Therefore, I will correct the tests. It may look like there are many differences, but in reality, I've only changed three tests from false to true and grouped them together. |
| */ | ||
| public function test_wp_insert_post_handle_malformed_post_date( $input, $expected ) { | ||
| $post = array( | ||
| 'post_author' => self::$editor_id, |
There was a problem hiding this comment.
Was this referencing a variable that doesn't exist?
There was a problem hiding this comment.
Yes, I believe the variable was changed by this commit.
06ef70d#diff-8da4b7dbfcc892321314b557b811accffd33adc7e407ac65cda306930c817957
There was a problem hiding this comment.
Got it. So it seems a stale patch was committed.
2 participants
Trac ticket: https://core.trac.wordpress.org/ticket/26798
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.