Skip to content

Bump JSHint esversion config from 10 to 11 #10808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
westonruter wants to merge 1 commit into from
+1 −4
Closed

Bump JSHint esversion config from 10 to 11 #10808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .jshintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"curly": true,
"eqeqeq": true,
"eqnull": true,
"esversion": 10,
"esversion": 11,
"expr": true,
"immed": true,
"noarg": true,
Expand Down
1 change: 0 additions & 1 deletion Gruntfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
/* jshint node:true */
/* jshint esversion: 6 */
/* eslint-env es6 */
/* globals Set */
var webpackConfig = require( './webpack.config' );
Expand Down
1 change: 0 additions & 1 deletion tools/webpack/codemirror-banner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
/* jshint node:true */
/* jshint esversion: 6 */
const codemirrorVersion = require( 'codemirror/package.json' ).version;
if ( typeof codemirrorVersion !== 'string' ) {
throw new Error( 'Could not read CodeMirror version from package.json' );
Expand Down
1 change: 0 additions & 1 deletion tools/webpack/codemirror.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
/* jshint node:true */
/* jshint esversion: 6 */
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why it add here 6 while the esversion is 10?

Copy link
Member

@sirreal sirreal Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect that was just copied from the main Gruntfile in r61539, but was never necessary.

Copy link
Member

@mukeshpanchal27 mukeshpanchal27 Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

const path = require( 'path' );
const webpack = require( 'webpack' );
const TerserPlugin = require( 'terser-webpack-plugin' );
Expand Down
Loading