Reduce code duplication in tests that upload file as attachment. #3102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mukeshpanchal27
left a comment
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Thanks @martinkrcho, Left some feedbacks.
martinkrcho
force-pushed
the
fix/56248-file-upload-tests-improvement
branch
from
476cfe3 to
e422c35
Compare
martinkrcho
requested review from
mukeshpanchal27
and removed request for
hellofromtonya
Author
|
@hellofromtonya I accidentally removed you from the reviewers. Anyway, the code is refactored to use a trait now and ready for another review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR introduces a new method
WP_UnitTestCase_Base::_upload_file_and_make_attachment()that uploads given file and creates an attachment post from it.It also replaces all occurrences of the repetitive code - with the exception of few places where extra tests are ran to check the result of
wp_upload_bits()call.Trac ticket: https://core.trac.wordpress.org/ticket/56248
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.