Increase default for wp_omit_loading_attr_threshold to 3
#4428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixarntz
reviewed
May 8, 2023
There was a problem hiding this comment.
@kt-12 The code so far looks good, however there are test failures, see e.g. https://github.com/WordPress/wordpress-develop/actions/runs/4883643267/jobs/8715275896?pr=4428#step:17:300.
I think a simple way to fix them would be to update the relevant tests to use the wp_omit_loading_attr_threshold filter to return 1 like before.
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
…-develop into enhancement/58213
|
@felixarntz This is good for review. I have fixed both the test error (here) by using |
westonruter
reviewed
May 15, 2023
westonruter
reviewed
May 15, 2023
felixarntz
reviewed
May 15, 2023
There was a problem hiding this comment.
Left a few follow up comments, no additional feedback beyond what @westonruter and @spacedmonkey pointed out.
spacedmonkey
approved these changes
May 16, 2023
|
Committed in https://core.trac.wordpress.org/changeset/55816 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/58213
Increase
wp_omit_loading_attr_thresholdthreshold to 3This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.