Skip to content

Conversation

@desrosj
Copy link
Member

@desrosj desrosj commented Oct 9, 2024

Trac ticket: https://core.trac.wordpress.org/ticket/52668


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@desrosj desrosj self-assigned this Oct 9, 2024
@desrosj desrosj requested review from Clorith and afercia October 9, 2024 18:55
@github-actions
Copy link

github-actions bot commented Oct 9, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props desrosj, poena.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

github-actions bot commented Oct 9, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@desrosj desrosj requested a review from carolinan October 17, 2024 17:57
@desrosj
Copy link
Member Author

desrosj commented Oct 17, 2024

👋 @carolinan I added you as a reviewer because Andrea said you were the person having issues. Whenever you have a chance, could you please just give this PR a test to see if the issue is fixed?

@carolinan
Copy link
Contributor

I can confirm that the docker containers start without problems when I use the command npm run env:start
Windows 11 Pro OS Version 22631.4317

@desrosj
Copy link
Member Author

desrosj commented Oct 18, 2024

Thanks everyone. Merged in https://core.trac.wordpress.org/changeset/59249.

@desrosj desrosj closed this Oct 18, 2024
@desrosj desrosj deleted the fix/docker-on-windows branch October 18, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants