[PHP.wasm] Emscripten v4.0.19 won't crash on php crash test

[mho22]

Mentionned in this pull request.

Upgrading emscripten will make the Does not crash due to an unhandled Asyncify error fail successfully.

It looks like it doesn't crash anymore.

It should normally crash in 7.2 7.3 7.4 8.0 8.1 with the following stack trace :

RuntimeError: unreachable
    at zend_execute_scripts (wasm://wasm/php.wasm-06d40b82:1:6054295)
    at dynCall_iiiii (wasm://wasm/php.wasm-06d40b82:1:16108803)
    at Object.ret.<computed> [as dynCall_iiiii] (wordpress-playground/packages/php-wasm/node/asyncify/php_7_4.js:18430:15)
    at invoke_iiiii (wordpress-playground/packages/php-wasm/node/asyncify/php_7_4.js:35248:34)
    at php_execute_script (wasm://wasm/php.wasm-06d40b82:1:5567965)
    at dynCall_ii (wasm://wasm/php.wasm-06d40b82:1:16108348)
    at Object.ret.<computed> [as dynCall_ii] (wordpress-playground/packages/php-wasm/node/asyncify/php_7_4.js:18430:15)
    at invoke_ii (wordpress-playground/packages/php-wasm/node/asyncify/php_7_4.js:35270:31)
    at wasm_sapi_handle_request (wasm://wasm/php.wasm-06d40b82:1:6806886)
    at ret.<computed> (wordpress-playground/packages/php-wasm/node/asyncify/php_7_4.js:18430:15) {
  cause: Error:
      at Object.Asyncify.handleSleep (wordpress-playground/packages/php-wasm/node/asyncify/php_7_4.js:35895:41)
      at returnCallback (wordpress-playground/packages/php-wasm/node/asyncify/php_7_4.js:32206:49)
      at wasm_poll_socket (wordpress-playground/packages/php-wasm/node/asyncify/php_7_4.js:32213:10)
      at php_pollfd_for (wasm://wasm/php.wasm-06d40b82:1:6801372)
      at php_sockop_read (wasm://wasm/php.wasm-06d40b82:1:5716644)
      at php_openssl_sockop_io (wasm://wasm/php.wasm-06d40b82:1:2452438)
      at php_openssl_sockop_read (wasm://wasm/php.wasm-06d40b82:1:2454068)
      at _php_stream_fill_read_buffer (wasm://wasm/php.wasm-06d40b82:1:5655656)
      at _php_stream_get_line (wasm://wasm/php.wasm-06d40b82:1:5660030)
      at php_stream_url_wrap_http_ex (wasm://wasm/php.wasm-06d40b82:1:5228125)
}

Or crash in 8.2 8.3 8.4 with the following stack trace :

RuntimeError: null function or function signature mismatch
    at execute_ex (wasm://wasm/php.wasm-08397aae:1:6669762)
    at zend_execute (wasm://wasm/php.wasm-08397aae:1:6671059)
    at zend_execute_scripts (wasm://wasm/php.wasm-08397aae:1:6496558)
    at dynCall_iiiii (wasm://wasm/php.wasm-08397aae:1:19958419)
    at Object.ret.<computed> [as dynCall_iiiii] (wordpress-playground/packages/php-wasm/node/asyncify/php_8_2.js:18438:15)
    at invoke_iiiii (wordpress-playground/packages/php-wasm/node/asyncify/php_8_2.js:35262:34)
    at php_execute_script (wasm://wasm/php.wasm-08397aae:1:5964098)
    at dynCall_ii (wasm://wasm/php.wasm-08397aae:1:19957964)
    at Object.ret.<computed> [as dynCall_ii] (wordpress-playground/packages/php-wasm/node/asyncify/php_8_2.js:18438:15)
    at invoke_ii (wordpress-playground/packages/php-wasm/node/asyncify/php_8_2.js:35284:31) {
  cause: Error:
      at Object.Asyncify.handleSleep (wordpress-playground/packages/php-wasm/node/asyncify/php_8_2.js:36102:41)
      at returnCallback (wordpress-playground/packages/php-wasm/node/asyncify/php_8_2.js:32206:49)
      at wasm_poll_socket (wordpress-playground/packages/php-wasm/node/asyncify/php_8_2.js:32213:10)
      at php_pollfd_for (wasm://wasm/php.wasm-08397aae:1:7679108)
      at php_sockop_read (wasm://wasm/php.wasm-08397aae:1:6116157)
      at php_openssl_sockop_io (wasm://wasm/php.wasm-08397aae:1:2692270)
      at php_openssl_sockop_read (wasm://wasm/php.wasm-08397aae:1:2693900)
      at _php_stream_fill_read_buffer (wasm://wasm/php.wasm-08397aae:1:6049743)
      at _php_stream_get_line (wasm://wasm/php.wasm-08397aae:1:6054233)
      at php_stream_url_wrap_http_ex (wasm://wasm/php.wasm-08397aae:1:5624220)
}

What happened ?

[mho22]

I rose the --stack-trace-limit and got these new stack traces :

8.2

RuntimeError: null function or function signature mismatch
    at execute_ex (wasm://wasm/php.wasm-08397aae:1:6669762)
    at zend_execute (wasm://wasm/php.wasm-08397aae:1:6671059)
    ... 14 lines matching cause stack trace ...
    at processTicksAndRejections (node:internal/process/task_queues:105:5) {
  cause: Error:
      at Object.Asyncify.handleSleep (wordpress-playground/packages/php-wasm/node/asyncify/php_8_2.js:36102:41)
      at returnCallback (wordpress-playground/packages/php-wasm/node/asyncify/php_8_2.js:32206:49)
      at wasm_poll_socket (wordpress-playground/packages/php-wasm/node/asyncify/php_8_2.js:32213:10)
      at php_pollfd_for (wasm://wasm/php.wasm-08397aae:1:7679108)
      at php_sockop_read (wasm://wasm/php.wasm-08397aae:1:6116157)
      at php_openssl_sockop_io (wasm://wasm/php.wasm-08397aae:1:2692270)
      at php_openssl_sockop_read (wasm://wasm/php.wasm-08397aae:1:2693900)
      at _php_stream_fill_read_buffer (wasm://wasm/php.wasm-08397aae:1:6049743)
      at _php_stream_get_line (wasm://wasm/php.wasm-08397aae:1:6054233)
      at php_stream_url_wrap_http_ex (wasm://wasm/php.wasm-08397aae:1:5624220)
      at php_stream_url_wrap_http (wasm://wasm/php.wasm-08397aae:1:5610170)
      at _php_stream_open_wrapper_ex (wasm://wasm/php.wasm-08397aae:1:6066295)
      at zif_file_get_contents (wasm://wasm/php.wasm-08397aae:1:5335730)
      at phar_file_get_contents (wasm://wasm/php.wasm-08397aae:1:4389994)
      at ZEND_DO_ICALL_SPEC_RETVAL_UNUSED_HANDLER (wasm://wasm/php.wasm-08397aae:1:7017760)
      at execute_ex (wasm://wasm/php.wasm-08397aae:1:6669762)
      at zend_call_function (wasm://wasm/php.wasm-08397aae:1:6400570)
      at zend_call_known_function (wasm://wasm/php.wasm-08397aae:1:6402560)
      at zend_objects_clone_members (wasm://wasm/php.wasm-08397aae:1:7279546)
      at zend_objects_clone_obj (wasm://wasm/php.wasm-08397aae:1:7279878)
      at ZEND_CLONE_SPEC_CV_HANDLER (wasm://wasm/php.wasm-08397aae:1:6967073)
      at execute_ex (wasm://wasm/php.wasm-08397aae:1:6669762)
      at zend_execute (wasm://wasm/php.wasm-08397aae:1:6671059)
      at zend_execute_scripts (wasm://wasm/php.wasm-08397aae:1:6496558)
      at dynCall_iiiii (wasm://wasm/php.wasm-08397aae:1:19958419)
      at Object.ret.<computed> [as dynCall_iiiii] (wordpress-playground/packages/php-wasm/node/asyncify/php_8_2.js:18438:15)
      at invoke_iiiii (wordpress-playground/packages/php-wasm/node/asyncify/php_8_2.js:35262:34)
      at php_execute_script (wasm://wasm/php.wasm-08397aae:1:5964098)
      at dynCall_ii (wasm://wasm/php.wasm-08397aae:1:19957964)
      at Object.ret.<computed> [as dynCall_ii] (wordpress-playground/packages/php-wasm/node/asyncify/php_8_2.js:18438:15)
      at invoke_ii (wordpress-playground/packages/php-wasm/node/asyncify/php_8_2.js:35284:31)
      at wasm_sapi_handle_request (wasm://wasm/php.wasm-08397aae:1:7685258)
      at ret.<computed> (wordpress-playground/packages/php-wasm/node/asyncify/php_8_2.js:18438:15)
      at runtime.wasmExports.<computed> (wordpress-playground/packages/php-wasm/universal/src/lib/wasm-error-reporting.ts:59:13)
      at Object.doRewind (wordpress-playground/packages/php-wasm/node/asyncify/php_8_2.js:18547:11)
      at wordpress-playground/packages/php-wasm/node/asyncify/php_8_2.js:18576:39
      at wordpress-playground/packages/php-wasm/node/asyncify/php_8_2.js:32327:6
      at processTicksAndRejections (node:internal/process/task_queues:105:5)
}

And 7.2

RuntimeError: unreachable
    at zend_execute_scripts (wasm://wasm/php.wasm-06a37766:1:5910529)
    at dynCall_iiiii (wasm://wasm/php.wasm-06a37766:1:16040714)
    ... 10 lines matching cause stack trace ...
    at wordpress-playground/packages/php-wasm/node/asyncify/php_7_2.js:18564:39
    at wordpress-playground/packages/php-wasm/node/asyncify/php_7_2.js:32327:6
    at processTicksAndRejections (node:internal/process/task_queues:105:5) {
  cause: Error:
      at Object.Asyncify.handleSleep (wordpress-playground/packages/php-wasm/node/asyncify/php_7_2.js:35882:41)
      at returnCallback (wordpress-playground/packages/php-wasm/node/asyncify/php_7_2.js:32206:49)
      at wasm_poll_socket (wordpress-playground/packages/php-wasm/node/asyncify/php_7_2.js:32213:10)
      at php_pollfd_for (wasm://wasm/php.wasm-06a37766:1:6732182)
      at php_sockop_read (wasm://wasm/php.wasm-06a37766:1:5569566)
      at php_openssl_sockop_io (wasm://wasm/php.wasm-06a37766:1:2454872)
      at php_openssl_sockop_read (wasm://wasm/php.wasm-06a37766:1:2456439)
      at _php_stream_fill_read_buffer (wasm://wasm/php.wasm-06a37766:1:5512035)
      at _php_stream_get_line (wasm://wasm/php.wasm-06a37766:1:5515707)
      at php_stream_url_wrap_http_ex (wasm://wasm/php.wasm-06a37766:1:5088826)
      at php_stream_url_wrap_http (wasm://wasm/php.wasm-06a37766:1:5074822)
      at _php_stream_open_wrapper_ex (wasm://wasm/php.wasm-06a37766:1:5526746)
      at zif_file_get_contents (wasm://wasm/php.wasm-06a37766:1:4819247)
      at phar_file_get_contents (wasm://wasm/php.wasm-06a37766:1:4000193)
      at ZEND_DO_ICALL_SPEC_RETVAL_UNUSED_HANDLER (wasm://wasm/php.wasm-06a37766:1:6532172)
      at execute_ex (wasm://wasm/php.wasm-06a37766:1:6224341)
      at zend_call_function (wasm://wasm/php.wasm-06a37766:1:5818287)
      at zend_call_method (wasm://wasm/php.wasm-06a37766:1:6055034)
      at zend_objects_clone_members (wasm://wasm/php.wasm-06a37766:1:6166145)
      at zend_objects_clone_obj (wasm://wasm/php.wasm-06a37766:1:6166458)
      at ZEND_CLONE_SPEC_CV_HANDLER (wasm://wasm/php.wasm-06a37766:1:6479330)
      at execute_ex (wasm://wasm/php.wasm-06a37766:1:6224341)
      at zend_execute (wasm://wasm/php.wasm-06a37766:1:6225468)
      at zend_execute_scripts (wasm://wasm/php.wasm-06a37766:1:5910311)
      at dynCall_iiiii (wasm://wasm/php.wasm-06a37766:1:16040714)
      at Object.ret.<computed> [as dynCall_iiiii] (wordpress-playground/packages/php-wasm/node/asyncify/php_7_2.js:18426:15)
      at invoke_iiiii (wordpress-playground/packages/php-wasm/node/asyncify/php_7_2.js:35246:34)
      at php_execute_script (wasm://wasm/php.wasm-06a37766:1:5427452)
      at dynCall_ii (wasm://wasm/php.wasm-06a37766:1:16040489)
      at Object.ret.<computed> [as dynCall_ii] (wordpress-playground/packages/php-wasm/node/asyncify/php_7_2.js:18426:15)
      at invoke_ii (wordpress-playground/packages/php-wasm/node/asyncify/php_7_2.js:35268:31)
      at wasm_sapi_handle_request (wasm://wasm/php.wasm-06a37766:1:6737671)
      at ret.<computed> (wordpress-playground/packages/php-wasm/node/asyncify/php_7_2.js:18426:15)
      at runtime.wasmExports.<computed> (wordpress-playground/packages/php-wasm/universal/src/lib/wasm-error-reporting.ts:59:13)
      at Object.doRewind (wordpress-playground/packages/php-wasm/node/asyncify/php_7_2.js:18535:11)
      at wordpress-playground/packages/php-wasm/node/asyncify/php_7_2.js:18564:39
      at Timeout._onTimeout (wordpress-playground/packages/php-wasm/node/asyncify/php_7_2.js:32338:7)
      at listOnTimeout (node:internal/timers:608:17)
      at processTimers (node:internal/timers:543:7)
}

[adamziel]

Yeah, we need it to crash as that is a very clear indication we've missed something related to Asyncify. Those stack-traces also carry a lot of valuable information. The alternative, that is hanging indefinitely, would make debugging impossible.

[mho22]

@adamziel I can't tell right now if emscripten 4.0.19 made the above situation not crash are if they removed the global crash behavior to make it more "smooth".

The next Does not crash due to an unhandled non promise error test is still crashing as expected but I guess you want a test that intentionally makes Asyncify crash ?

[adamziel]

The next Does not crash due to an unhandled non promise error test is still crashing as expected but I guess you want a test that intentionally makes Asyncify crash?

Yes, otherwise we won't get error details when a real crash occurs.

[mho22]

I rearranged the test code and the test passed again. Let's wait for the results.