Skip to content

[ Intl ] disable Intl functions in bootWordpress by default #2247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 16, 2025
Merged

[ Intl ] disable Intl functions in bootWordpress by default #2247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5d094c3
add withICU in bootWordpress and disable intl functions if false
mho22 Jun 9, 2025
12c4f15
rename icu with intl in blueprints
mho22 Jun 10, 2025
48b9f4b
Added intl tests in playwright
mho22 Jun 10, 2025
3999845
Add a skip on a test due to unknown issues on Chromium
mho22 Jun 13, 2025
80772fe
Merge branch 'trunk' into disable-intl-functions-in-worker-threads-by…
mho22 Jun 13, 2025
b160e05
Refactor tests and correct typing error in vite.config.js
mho22 Jun 13, 2025
47600f0
Merge branch 'trunk' into disable-intl-functions-in-worker-threads-by…
bgrgicak Jun 13, 2025
19578a9
Merge branch 'trunk' into disable-intl-functions-in-worker-threads-by…
mho22 Jun 14, 2025
165caa7
Merge branch 'trunk' into disable-intl-functions-in-worker-threads-by…
mho22 Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/php-wasm/node/src/test/php.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2166,10 +2166,10 @@ bar1
it('Should be able to use intl functions', async () => {
const response = await php.run({
code: `<?php
$formatter = new NumberFormatter('en-US', NumberFormatter::CURRENCY);
echo $formatter->format(100.00);
$formatter = new NumberFormatter('fr-FR', NumberFormatter::CURRENCY);
echo $formatter->format(100.00);
$formatter = numfmt_create('en-US', NumberFormatter::CURRENCY);
echo numfmt_format($formatter, 100.00);
$formatter = numfmt_create('fr-FR', NumberFormatter::CURRENCY);
echo numfmt_format($formatter, 100.00);
?>`,
});
expect(response.text).toEqual('$100.00100,00\xA0€');
Expand Down
2 changes: 1 addition & 1 deletion packages/php-wasm/web/vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ export default defineConfig(({ command }) => {
// the preserve-php-loaders-imports plugin above.
external: [
/php_\d_\d.js$/,
/icudt74l\.js$/,
/icudt74l.js$/,
...getExternalModules(),
],
},
Expand Down
Loading
Loading