PHP: Stream stdout and stderr #2261
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
[Type] Enhancement
adamziel
force-pushed
the
push-szvonsvruzmv
branch
3 times, most recently
from
15bf8ed to
53e5126
Compare
bgrgicak
reviewed
Jun 12, 2025
| // @TODO: Why are we logging things so eagerly? Shouldn't | ||
| // the caller handle that? There's so much noise in | ||
| // the console. | ||
| // logger.error(rethrown); |
There was a problem hiding this comment.
I found the original PR and it looks like I just replaced all console.error calls with logger.error, so this might be a good time to rethink if we really need these log entries.
There was a problem hiding this comment.
Aha, good spot! Thank you
adamziel
force-pushed
the
push-szvonsvruzmv
branch
7 times, most recently
from
f3bca7e to
4c5aa92
Compare
adamziel
force-pushed
the
push-oznxvtpzqmzr
branch
from
1271db7 to
5cfa0e9
Compare
adamziel
force-pushed
the
push-oznxvtpzqmzr
branch
7 times, most recently
from
7f310d7 to
58956fc
Compare
Implements a php.runStream() method that returns a StreamedPHPResponse instance. It exposes stdout and stderr as ReadableStreams, allowing the caller to interact with partial output data. Before this PR, we only had php.run() that buffered stdout and stderr data and returned it all at once after the PHP code was fully executed. ## Implementation We register three FS devices at: * /internal/stdout * /internal/stderr * /internal/headers They are private to every PHP instance and are never shared with other runtimes. Then, in JavaScript, whenever a chunk of data is written to either of these devices, we propagate it to consumer via a callback, e.g. `PHPWASM.onStdout(chunk)`. Users of the `PHP` class never have to interact with these devices or callbacks directly. The PHP class creates the relevant ReadableStreams and pushes the data through them – see php.#executeWithErrorHandling() for details. #### Why not use Emscripten's stdout and stderr? Emscripten's native stdout and stderr devices stop processing data when they encounter the first null byte. However, null bytes are common when dealing with binary data. ### Backwards Compatibility php.run() continues to work. It creates a streamed response under the hood and buffers the streamed output before returning a buffered `PHPResponse` object. ## Remaining work * Add streaming-specific tests ## Follow-up work * Stream the response bytes in the web/service worker Remove old PHP CLI bindings
adamziel
force-pushed
the
push-oznxvtpzqmzr
branch
from
58956fc to
e64002f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a php.runStream() method that returns a StreamedPHPResponse instance.
It exposes stdout and stderr as ReadableStreams, allowing the caller to interact
with partial output data. Before this PR, we only had php.run() that buffered
stdout and stderr data and returned it all at once after the PHP code was fully
executed.
Implementation
We register three FS devices at:
They are private to every PHP instance and are never shared with other runtimes.
Then, in JavaScript, whenever a chunk of data is written to either of these devices, we propagate
it to consumer via a callback, e.g.
PHPWASM.onStdout(chunk).Users of the
PHPclass never have to interact with these devices or callbacks directly.The PHP class creates the relevant ReadableStreams and pushes the data through them
– see php.#executeWithErrorHandling() for details.
Why not use Emscripten's stdout and stderr?
Emscripten's native stdout and stderr devices stop processing data when they encounter
the first null byte. However, null bytes are common when dealing with binary data.
Backwards Compatibility
php.run() continues to work. It creates a streamed response under the hood and buffers
the streamed output before returning a buffered
PHPResponseobject.Remaining work
Follow-up work