Skip to content

Conversation

@adamziel
Copy link
Collaborator

Motivation for the change, related issues

Before this PR, this step would fail:

{
		"step": "installPlugin",
		"pluginData": {
			"resource": "git:directory",
			"url": "https://github.com/juanma-wp/meetup-cheltenham-workshop/",
			"ref": "final",
			"path": "/"
		},
		"options": {
			"activate": true
		}
},

This is because installPlugin names the plugin directory inside wp-content after the filename of the resolved resource, and the git:directory resource would use path to generate a filename called /.

With this PR, git:directory generates a directory name using the full set of information from the resource spec: URL, ref, path. The names are now more like this: https-github.com-WordPress-wordpress-playground-trunk.

Testing Instructions (or ideally a Blueprint)

CI – this PR comes with tests

cc @juanmaguitar

@adamziel adamziel merged commit c0a619f into trunk Oct 14, 2025
27 checks passed
@adamziel adamziel deleted the blueprints-git-resource-always-return-non-empty-name branch October 14, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant