[Blueprints] ensure git:directory resource returns non-empty-name #2779
+68
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
Before this PR, this step would fail:
This is because
installPluginnames the plugin directory insidewp-contentafter the filename of the resolved resource, and thegit:directoryresource would usepathto generate a filename called/.With this PR,
git:directorygenerates a directory name using the full set of information from the resource spec: URL, ref, path. The names are now more like this:https-github.com-WordPress-wordpress-playground-trunk.Testing Instructions (or ideally a Blueprint)
CI – this PR comes with tests
cc @juanmaguitar