Skip to content

Conversation

@adamziel
Copy link
Collaborator

Motivation for the change, related issues

I've noticed Playground did not rewrite this particular URL as a raw.githubusercontent URL:

https://github.com/adamziel/blueprints/raw/f49382e89099806a8eede4feba41a9a7ab89bcfe/blueprints%2Fbeta-rc%2Fblueprint.json

This PR adds a support for that in the UrlResource.

Testing Instructions (or ideally a Blueprint)

@adamziel adamziel marked this pull request as ready for review November 13, 2025 14:44
@adamziel
Copy link
Collaborator Author

The CLI failure seems unrelated to this PR:

2025-11-13T14:27:10.6533014Z �[31m�[1m�[7m FAIL �[27m�[22m�[39m tests/run-cli.spec.ts�[2m > �[22mrun-cli with Blueprints v1�[2m > �[22mverbosity�[2m > �[22mshould output main logs by default
2025-11-13T14:27:10.6533476Z �[31m�[1mAssertionError�[22m: expected [ 'Starting a PHP server...', …(13) ] to deeply equal ArrayContaining{…}�[39m
2025-11-13T14:27:10.6533484Z 
2025-11-13T14:27:10.6533650Z �[32m- Expected�[39m
2025-11-13T14:27:10.6533773Z �[31m+ Received�[39m
2025-11-13T14:27:10.6533781Z 
2025-11-13T14:27:10.6533921Z �[32m- ArrayContaining [�[39m
2025-11-13T14:27:10.6534032Z �[31m+ Array [�[39m
2025-11-13T14:27:10.6534203Z �[2m    "Starting a PHP server...",�[22m
2025-11-13T14:27:10.6534625Z �[31m+   "Native temp dir for VFS root: /tmp/node-playground-cli-site-2577--2577-xyQev52aPvW4",�[39m
2025-11-13T14:27:10.6535065Z �[31m+   "Mount before WP install: /home -> /tmp/node-playground-cli-site-2577--2577-xyQev52aPvW4/home",�[39m
2025-11-13T14:27:10.6535495Z �[31m+   "Mount before WP install: /tmp -> /tmp/node-playground-cli-site-2577--2577-xyQev52aPvW4/tmp",�[39m
2025-11-13T14:27:10.6536075Z �[31m+   "Mount before WP install: /wordpress -> /tmp/node-playground-cli-site-2577--2577-xyQev52aPvW4/wordpress",�[39m
2025-11-13T14:27:10.6536247Z �[2m    "Starting up workers",�[22m
2025-11-13T14:27:10.6536777Z �[32m-   StringMatching /^Resolved WordPress release URL: https:\/\/downloads\.w\.org\/release\/wordpress-\d+\.\d+\.\d+\.zip$/,�[39m
2025-11-13T14:27:10.6537230Z �[31m+   "Resolved WordPress release URL: https://downloads.wordpress.org/release/wordpress-6.9-RC1.zip",�[39m
2025-11-13T14:27:10.6537437Z �[2m    "Fetching SQLite integration plugin...",�[22m
2025-11-13T14:27:10.6537598Z �[2m    "Booting WordPress...",�[22m
2025-11-13T14:27:10.6537721Z �[2m    "Booted!",�[22m
2025-11-13T14:27:10.6537890Z �[2m    "Running the Blueprint...",�[22m
2025-11-13T14:27:10.6538078Z �[2m    "Finished running the blueprint",�[22m
2025-11-13T14:27:10.6538234Z �[2m    "Preparing workers...",�[22m
2025-11-13T14:27:10.6538638Z �[32m-   StringMatching /^WordPress is running on http:\/\/127\.0\.0\.1:\d+ with \d+ worker\(s\)$/,�[39m
2025-11-13T14:27:10.6538993Z �[31m+   "WordPress is running on http://127.0.0.1:45833 with 1 worker(s)",�[39m
2025-11-13T14:27:10.6539100Z �[2m  ]�[22m
2025-11-13T14:27:10.6539109Z

@adamziel adamziel merged commit d8ebf50 into trunk Nov 13, 2025
28 of 29 checks passed
@adamziel adamziel deleted the support-raw-urls branch November 13, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants