[Website] Enforce HTTPS in fetchWithCorsProxy() #2901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@copilot run HTTPS server in |
Contributor
…2903) ## Motivation for the change, related issues `fetchWithCorsProxy` now upgrades HTTP URLs to HTTPS. Tests making requests to `http://127.0.0.1:PORT` get upgraded to `https://127.0.0.1:PORT`, requiring an HTTPS test server. ## Implementation details **Test server migration to HTTPS** - Generate self-signed certificates with SANs for `127.0.0.1` using `selfsigned` library - Convert Express server from `app.listen()` to `https.createServer()` - Set `NODE_TLS_REJECT_UNAUTHORIZED=0` for test environment **Fix request body stream handling** - `cloneRequest()` was calling `await request.blob()` to clone requests with bodies - This hung on POST requests because the body stream was still awaiting data that would never arrive - Solution: Reuse unconsumed body streams directly via `request.body` instead of reading to Blob ```typescript // Before: Hangs when body stream is still open const body = await request.blob(); // After: Reuses stream when possible const body = !request.bodyUsed && request.body ? request.body : await request.blob(); ``` - Added `duplex: 'half'` to Request creation for Node.js streaming body compatibility - Removed unused `@ts-expect-error` directive as TypeScript now properly recognizes the `duplex` property ## Testing Instructions (or ideally a Blueprint) CI. All 31 tests in `tcp-over-fetch-websocket.spec.ts` pass, including POST requests with bodies. <!-- START COPILOT CODING AGENT TIPS --> --- ✨ Let Copilot coding agent [set things up for you](https://github.com/WordPress/wordpress-playground/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: adamziel <205419+adamziel@users.noreply.github.com> Co-authored-by: Adam Zieliński <adam@adamziel.com>
adamziel
changed the title
Remove unnecessary comment about duplex in Node.js.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
I've noticed
fetchWithCorsProxysometimes fails when it gets anhttpURL. Since browsers frown uponhttpfetches inhttpscontext, this PR enforces HTTPS as a protocol in those requests to resolves the following error:Testing Instructions (or ideally a Blueprint)
CI, new test is shipped with this PR.