Skip to content

Add file locking integration tests for php-wasm/node #2908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Nov 18, 2025
Merged

Add file locking integration tests for php-wasm/node #2908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
ed675c3
Add test scaffolding
brandonpayton Nov 15, 2025
fcf3700
Outline tests
brandonpayton Nov 16, 2025
68338db
Start adding php-wasm tests for file locking
brandonpayton Nov 16, 2025
1049420
Improve test TODOs
brandonpayton Nov 17, 2025
57cc444
Try using Claude to fill in remaining tests
brandonpayton Nov 17, 2025
04b3d10
Fix flock() locks to be released when fd closed
brandonpayton Nov 17, 2025
a1493bc
Remove the .only() test isolation
brandonpayton Nov 17, 2025
2b1b3f6
Upgrade Prettier to support TypeScript using keyword
brandonpayton Nov 17, 2025
b4b9430
Merge branch 'trunk' into php-wasm/file-locking-integration-tests
brandonpayton Nov 17, 2025
6e27fe1
Rebuild @php-wasm/node with flock() fix
brandonpayton Nov 18, 2025
4ccb36a
Add file locking tests to CI
brandonpayton Nov 18, 2025
6cbfcbc
Stop polluting test output with trace messages
brandonpayton Nov 18, 2025
6bd0269
Avoid missing DB failure for PHP 8.0 and below
brandonpayton Nov 18, 2025
0f90a44
Remove unnecessary try/catch
brandonpayton Nov 18, 2025
14faf65
Improve comment about DB existence check
brandonpayton Nov 18, 2025
001d5da
Move sync to promised wrapper to php-wasm/util
brandonpayton Nov 18, 2025
5167bd7
Improve organization of file lock tests
brandonpayton Nov 18, 2025
5729ba7
Fix Blueprint schema generator to use updated Prettier version
brandonpayton Nov 18, 2025
385aaaf
Remove redundant tests from test-asyncify
brandonpayton Nov 18, 2025
3e5b6c8
Some tweaks after reviewing AI-generated tests
brandonpayton Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 19 additions & 15 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,22 +29,24 @@ jobs:
fail-fast: false
matrix:
include:
- name: test-unit-asyncify (1/8)
- name: test-unit-asyncify (1/9)
target: test
- name: test-unit-asyncify (2/8)
- name: test-unit-asyncify (2/9)
target: test-asyncify
- name: test-unit-asyncify (3/8)
- name: test-unit-asyncify (3/9)
target: test-php-file-get-contents-asyncify
- name: test-unit-asyncify (4/8)
- name: test-unit-asyncify (4/9)
target: test-php-fopen-asyncify
- name: test-unit-asyncify (5/8)
- name: test-unit-asyncify (5/9)
target: test-php-fsockopen-asyncify
- name: test-unit-asyncify (6/8)
- name: test-unit-asyncify (6/9)
target: test-php-gethostbyname-asyncify
- name: test-unit-asyncify (7/8)
- name: test-unit-asyncify (7/9)
target: test-php-mysqli-asyncify
- name: test-unit-asyncify (8/8)
- name: test-unit-asyncify (8/9)
target: test-php-sqlite3-asyncify
- name: test-unit-asyncify (9/9)
target: test-php-file-locking-asyncify
name: ${{ matrix.name }}
services:
mysql:
Expand Down Expand Up @@ -79,20 +81,22 @@ jobs:
fail-fast: false
matrix:
include:
- name: test-unit-jspi (1/7)
- name: test-unit-jspi (1/8)
target: test-jspi
- name: test-unit-jspi (2/7)
- name: test-unit-jspi (2/8)
target: test-php-file-get-contents-jspi
- name: test-unit-jspi (3/7)
- name: test-unit-jspi (3/8)
target: test-php-fopen-jspi
- name: test-unit-jspi (4/7)
- name: test-unit-jspi (4/8)
target: test-php-fsockopen-jspi
- name: test-unit-jspi (5/7)
- name: test-unit-jspi (5/8)
target: test-php-gethostbyname-jspi
- name: test-unit-jspi (6/7)
- name: test-unit-jspi (6/8)
target: test-php-mysqli-jspi
- name: test-unit-jspi (7/7)
- name: test-unit-jspi (7/8)
target: test-php-sqlite3-jspi
- name: test-unit-jspi (8/8)
target: test-php-file-locking-jspi
name: ${{ matrix.name }}
services:
mysql:
Expand Down
Loading