Skip to content

Conversation

@mho22
Copy link
Collaborator

@mho22 mho22 commented Nov 20, 2025

Motivation for the change, related issues

Based on this comment

The nx run playground-blueprints:"test:vite" command systematically fails due to 10 seconds timeout on the should activate a plugin file located in the plugins directory test.

IIRC I also faced that situation with the PHP.wasm node tests and adding dispose methods made the trick. Let's see if it works here too.

Implementation details

Adding the following portion of code where necessary :

afterEach(async () => {
	php.exit();
	await handler[Symbol.asyncDispose]();
});

Testing Instructions

CI

@mho22 mho22 changed the title [Blueprints] Add afterEach dispose functions in tests [Blueprints] Add dispose functions in afterEach hooks in tests Nov 20, 2025
@mho22 mho22 force-pushed the add-exit-methods-in-blueprints-tests branch from c4d083d to 91611e6 Compare November 20, 2025 10:03
@mho22
Copy link
Collaborator Author

mho22 commented Nov 20, 2025

It looks like it worked!

@mho22 mho22 marked this pull request as ready for review November 20, 2025 10:32
@adamziel adamziel merged commit 4d8ddd9 into trunk Nov 20, 2025
32 checks passed
@adamziel adamziel deleted the add-exit-methods-in-blueprints-tests branch November 20, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants