BAT-7558 - Simple list fields broken

[asiebert]

Pretty sure this is caused by MongoEngine/mongoengine#1129: in that PR, verbose_name is no longer an actual attribute of fields classes. I guess this issue has something to with this document wrapper, scouring fields and trying to ensure the presence of verbose_name on them:

django-mongodbforms/mongodbforms/documentoptions.py

Lines 187 to 188 in ebaa882

	if not hasattr(f, 'verbose_name') or f.verbose_name is None:
	f.verbose_name = capfirst(create_verbose_name(f.name))

When the form generators encounters a list field though, it tries to grab data from its field.field:

django-mongodbforms/mongodbforms/fieldgenerator.py

Line 338 in ebaa882

form_field = self.generate(field.field)

Sub-field that seems to be ignored by the wrapper, and thus does not have the optional verbose_name. If the list's field is declared explicitly with a verbose_name, the issue does not occur.

→ It seems acceptable for help_text to be undefined, so I'm doing the same for verbose_name.

[m-vdb]

if getattr(field, 'verbose_name', None):

[asiebert]

I wouldn't say that's strictly equivalent – the current condition will fail if field.verbose_name is an empty string

[m-vdb]

this is, and if you want to nitpick use getattr(field, 'verbose_name', '')

[asiebert]

Nevermind, you're correct 1dc7522 ✅