fix: do batch call to non-GET methods

Batch call were restricted to do only GET type methods (i.e. search, metadata, get)
With this fix you can do more than that, like create, edit, execute

Author: citizensas

package-lock.json

@@ -60,7 +60,7 @@
     "test:karma": "karma start karma.conf.js",
     "test:mocha": "mocha -r ts-node/register/transpile-only test/*.spec.ts",
     "e2e": "CI=true mocha --no-timeouts test/e2e.test.js",
-    "debug": "npm run test -- --auto-watch --browsers Chrome --no-single-run",
+    "debug": "npm run test:karma -- --auto-watch --browsers Chrome --no-single-run",
     "build": "rollup -c && tsc --emitDeclarationOnly -p ./tsconfig.json -d --declarationDir ./typings",
     "docs": "rm -rf ./docs/ && typedoc --out ./docs/ ./src/ --excludePrivate --excludeExternals --exclude \"**/*.spec.ts\" && touch ./docs/.nojekyll",
     "prepublish": "npm run build",

package.json

@@ -410,7 +410,11 @@ export class Api {
     ): Promise<any> {
         const clonedParams = {...params}
 
-        const options = this.getOptions(path, clonedParams, method)
+        const options = this.getOptions(
+            path,
+            clonedParams,
+            this._uriGenerationMode ? Api.Methods.GET : method
+        )
 
         const stringifiedFields = this.getFields(fields)
         if (stringifiedFields) {
@@ -428,9 +432,13 @@ export class Api {
         }
 
         if (this._uriGenerationMode) {
+            let appendGetMethod = ''
+            if (queryString.indexOf('method=') === -1) {
+                appendGetMethod = (queryString === '' ? '?' : '&') + 'method=' + Api.Methods.GET
+            }
             // @ts-ignore-line
             return (
-                path + queryString + (queryString === '' ? '?' : '&') + 'method=' + Api.Methods.GET
+                path + queryString + appendGetMethod
             )
         }
         return makeFetchCall(options.url + options.path + queryString, {

src/Api.ts

@@ -103,4 +103,23 @@ describe('Batch', function() {
 			should(match).has.length(3, 'should have 3 method=GET params')
 		})
 	})
+	describe('Populate proper "uri" for "execute" method without objID', function() {
+		beforeEach(function () {
+			this.api.batch(
+				batchApi => [
+					batchApi.execute('user', null, 'activateUsers', {userIDs: ['foo', 'bar']})
+				]
+			)
+		})
+
+		it('should request POST /batch', function () {
+			should(fetchMock.lastUrl()).equal(API_URL + '/attask/api-internal/batch')
+			should(fetchMock.lastOptions()).have.property('method', 'POST')
+		})
+		it('has exact body params', function () {
+			const {body} = fetchMock.lastOptions()
+			const expectedString = 'atomic=false&uri=user%3Fmethod%3DPUT%26action%3DactivateUsers%26userIDs%3Dfoo%26userIDs%3Dbar'
+			should(body).equals(expectedString)
+		})
+	})
 })