added tests for login and logout

Author: Hovhannes Babayan

src/plugins/login.js

@@ -11,7 +11,6 @@ module.exports = function(Api) {
         return new Promise(function (resolve, reject) {
             that.request('login', {username: username, password: password}, null, 'POST')
                 .then(function (data) {
-                    that.httpOptions.headers = that.httpOptions.headers || {};
                     that.httpOptions.headers.sessionID = data.sessionID;
                     resolve(data);
                 }, reject);

src/plugins/logout.js

@@ -6,7 +6,7 @@ module.exports = function(Api) {
     Api.prototype.logout = function () {
         var that = this;
         return new Promise(function (resolve, reject) {
-            that.request('logout', {sessionID: that.httpOptions.headers.sessionID}).then(function (result) {
+            that.request('logout', null, null, 'GET').then(function (result) {
                 if (result) {
                     delete that.httpOptions.headers.sessionID;
                     resolve(result.success);

src/plugins/request.js

@@ -27,7 +27,6 @@ module.exports = function(Api) {
         params = queryString.stringify(params);
         if (params) {
             if (requestHasData(options.method)) {
-                options.headers = options.headers || {};
                 options.headers['Content-Type'] = 'application/x-www-form-urlencoded';
                 options.headers['Content-Length'] = Buffer.byteLength(params);
             }

test/plugins/login.spec.js

@@ -0,0 +1,39 @@
+require('./../common');
+
+var Api = require('./../../').Api;
+
+
+describe('Api.login() method', function() {
+
+	var api;
+	var url = 'http://foobar:8080';
+
+	beforeEach(function () {
+		api = new Api({url: url});
+		sinon.stub(api, "request");
+	});
+
+	afterEach(function () {
+		api.request.restore(); // Unwraps the spy
+	});
+
+	it('should call request() with proper params', function() {
+		var username = 'bar',
+			password = 'baz';
+		api.login(username, password);
+		expect(api.request).to.have.callCount(1);
+		expect(api.request).to.have.been.calledWith("login", {username: username, password: password}, null, "POST");
+	});
+
+	it('should set sessionID in headers if login was ok', function(done) {
+		expect(api.httpOptions.headers.sessionID).to.equal(undefined);
+		api.request.resolves({
+			sessionID: 123
+		});
+		var promise = api.login('a', 'b');
+		expect(promise).to.be.fulfilled.then(function () {
+			expect(api.httpOptions.headers.sessionID).to.equal(123);
+			done();
+		});
+	});
+});

test/plugins/logout.spec.js

@@ -0,0 +1,35 @@
+require('./../common');
+
+var Api = require('./../../').Api;
+
+
+describe('Api.logout() method', function() {
+
+	var api;
+	var url = 'http://foobar:8080';
+
+	beforeEach(function () {
+		api = new Api({url: url});
+		sinon.stub(api, "request");
+	});
+
+	afterEach(function () {
+		api.request.restore(); // Unwraps the spy
+	});
+
+	it('should call request() with proper params', function() {
+		api.logout();
+		expect(api.request).to.have.callCount(1);
+		expect(api.request).to.have.been.calledWith("logout", null, null, "GET");
+	});
+
+	it('should remove sessionID from headers if logout was ok', function(done) {
+		api.httpOptions.headers.sessionID = 123;
+		api.request.resolves(true);
+		var promise = api.logout();
+		expect(promise).to.be.fulfilled.then(function () {
+			expect(api.httpOptions.headers.sessionID).to.equal(undefined);
+			done();
+		});
+	});
+});