adding support to make every call a get so this project will work with the nodebalancer

Author: ryan miller

src/Api.js

@@ -44,7 +44,9 @@ function Api(config) {
         host: parsed.hostname,
         port: parsed.port || (isHttps ? 443 : 80),
         withCredentials: false,
-        headers: {}
+        headers: {},
+        //=== true to make undefined result in false
+        alwaysUseGet : config.alwaysUseGet === true
     };
 
     // These params will be sent with each request

src/plugins/request.js

@@ -34,11 +34,17 @@ module.exports = function(Api) {
         }
 
         params = params || {};
-        util._extend(params, this.httpParams);
+        var options = {},
+            alwaysUseGet = this.httpOptions.alwaysUseGet;
+        
+        util._extend(options, this.httpOptions);
+        if (alwaysUseGet) {
+            params.method = method;
+        } else {
+            options.method = method;
+        }
 
-        var options = {};
         util._extend(options, this.httpOptions);
-        options.method = method;
         if (path.indexOf('/') === 0) {
             options.path = this.httpOptions.path + path;
         }
@@ -52,7 +58,7 @@ module.exports = function(Api) {
 
         params = queryString.stringify(params);
         if (params) {
-            if (requestHasData(options.method)) {
+            if (!alwaysUseGet && requestHasData(options.method)) {
                 options.headers['Content-Type'] = 'application/x-www-form-urlencoded';
                 options.headers['Content-Length'] = params.length;
             }
@@ -89,7 +95,7 @@ module.exports = function(Api) {
                 });
             });
             request.on('error', reject);
-            if (params && requestHasData(options.method)) {
+            if (!alwaysUseGet && params && requestHasData(options.method)) {
                 request.write(params);
             }
             request.end();

test/plugins/request.spec.js

@@ -212,4 +212,22 @@ describe('Api.request() method', function() {
 		var promise = api.request(path, params, fields, method);
 		expect(promise).to.be.rejectedWith({'message': 'fail'}).and.notify(done);
 	});
+    
+    it('should only use get if alwaysUseGet is true', function(done) {
+		var url = 'http://foobar:8080',
+			path = '/test',
+			method = 'DELETE';
+
+		nock(url)
+			.get('/attask/api' + path + '?method=DELETE')
+			.reply(200, {
+				data: {
+					'got': 'ok'
+				}
+			});
+
+		var api = new Api({url: url, alwaysUseGet: true});
+		var promise = api.request(path, undefined, undefined, method);
+		expect(promise).to.eventually.deep.equal({'got': 'ok'}).and.notify(done);
+	});
 });