fixed bug in execHandlingErrors when options were not being passed properly to shell.exec

Author: bhovhannes

gulpfile.js

@@ -89,16 +89,16 @@ function publishDocs(cb) {
 		currentDir = process.cwd();
 	shell.rm('-rf', ghPagesDir);
 	shell.mkdir(ghPagesDir);
-	execHandlingErrors('git clone -b gh-pages https://github.com/bhovhannes/attask-api.git "'+ghPagesDir+'"');
+	shellExec('git clone -b gh-pages https://github.com/bhovhannes/attask-api.git "'+ghPagesDir+'"');
 	shell.rm('-rf', path.join(ghPagesDir, '*'));
 
 	var stream = generateDocs(ghPagesDir);
 	stream.on('finish', function() {
 		shell.cd(ghPagesDir);
-		execHandlingErrors('git add -A .');
-		execHandlingErrors('git commit -m "Autogenerated new docs at ' + dateformat(new Date()) + '"');
-		execHandlingErrors('git fetch origin && git rebase origin/gh-pages');
-		execHandlingErrors('git push origin gh-pages');
+		shellExec('git add -A .');
+		shellExec('git commit -m "Autogenerated new docs at ' + dateformat(new Date()) + '"');
+		shellExec('git fetch origin && git rebase origin/gh-pages');
+		shellExec('git push origin gh-pages');
 
 		shell.cd(currentDir);
 		shell.rm('-rf', ghPagesDir);
@@ -126,7 +126,7 @@ function getVersionTags() {
 	var shell = require('shelljs'),
 		semver = require('semver');
 
-	var tags = splitCommandResultToLines(execHandlingErrors("git tag", { silent: true }));
+	var tags = splitCommandResultToLines(shellExec("git tag", { silent: true }));
 
 	return tags.reduce(function(list, tag) {
 		if (semver.valid(tag)) {
@@ -164,7 +164,7 @@ function generateChangelog() {
 	header.to("CHANGELOG.tmp");
 
 	// get log statements
-	var logs = execHandlingErrors("git log --pretty=format:\"* %s (%an)\" " + rangeTags.join(".."), {silent: true}).split(/\n/g);
+	var logs = shellExec("git log --pretty=format:\"* %s (%an)\" " + rangeTags.join(".."), {silent: true}).split(/\n/g);
 	logs = logs.filter(function(line) {
 		return line.indexOf("Merge pull request") === -1 && line.indexOf("Merge branch") === -1;
 	});
@@ -191,20 +191,20 @@ function release(type, cb) {
 	testsStream.on('error', cb);
 	testsStream.on('end', function() {
 		try {
-			var newVersion = execHandlingErrors("npm version " + type, { silent: true }).trim();
+			var newVersion = shellExec("npm version " + type, { silent: true }).trim();
 			generateChangelog();
 
 			// add changelog to commit
-			execHandlingErrors("git add CHANGELOG.md");
-			execHandlingErrors("git commit --amend --no-edit");
+			shellExec("git add CHANGELOG.md");
+			shellExec("git commit --amend --no-edit");
 
 			// replace existing tag
-			execHandlingErrors("git tag -f " + newVersion);
+			shellExec("git tag -f " + newVersion);
 
 			// push all the things
-			execHandlingErrors("git push origin master --tags");
+			shellExec("git push origin master --tags");
 
-			execHandlingErrors("npm publish");
+			shellExec("npm publish");
 			publishDocs(cb);
 		}
 		catch(e) {
@@ -213,9 +213,9 @@ function release(type, cb) {
 	});
 }
 
-function execHandlingErrors(cmd) {
+function shellExec() {
 	var shell = require('shelljs');
-	var execResult = shell.exec(cmd);
+	var execResult = shell.exec.apply(shell, arguments);
 	if (execResult.code) {
 		throw new Error(execResult.output);
 	}