more tests

Author: Hovhannes Babayan

src/plugins/request.js

@@ -5,7 +5,6 @@ module.exports = function(Api) {
     Api.prototype.request = function(path, params, fields, method) {
         params = params || {};
         fields = fields || [];
-        method = method || 'GET';
 
         var options = {};
         util._extend(options, this.httpOptions);
@@ -21,7 +20,10 @@ module.exports = function(Api) {
             params.fields = fields.join();
         }
 
-        options.path += '?' + queryString.stringify(params);
+        params = queryString.stringify(params);
+        if (params) {
+            options.path += '?' + params;
+        }
 
         var httpTransport = this.httpTransport;
 

test/plugins/RequestSpec.js

@@ -4,7 +4,7 @@ var nock = require('nock');
 var Api = require('./../../').Api;
 
 
-describe('Api. request() method', function() {
+describe('Api.request() method', function() {
 
 	it('should resolve returned promise with data if everything went ok', function(done) {
 		var url = 'http://foobar:8080',
@@ -31,6 +31,97 @@ describe('Api. request() method', function() {
 		expect(promise).to.eventually.deep.equal({'got': 'ok'}).and.notify(done);
 	});
 
+
+	it('should resolve returned promise with data if everything went ok (empty fields)', function(done) {
+		var url = 'http://foobar:8080',
+			path = '/test',
+			params = {
+				'foo': 1,
+				'bar': 'baz'
+			},
+			fields = [],
+			method = 'GET';
+
+		nock(url)
+			.get('/attask/api' + path + '?foo=1&bar=baz')
+			.reply(200, {
+				data: {
+					'got': 'ok'
+				}
+			});
+
+		var api = new Api({url: url});
+		var promise = api.request(path, params, fields, method);
+		expect(promise).to.eventually.deep.equal({'got': 'ok'}).and.notify(done);
+	});
+
+
+	it('should resolve returned promise with data if everything went ok (without fields)', function(done) {
+		var url = 'http://foobar:8080',
+			path = '/test',
+			params = {
+				'foo': 1,
+				'bar': 'baz'
+			},
+			method = 'GET';
+
+		nock(url)
+			.get('/attask/api' + path + '?foo=1&bar=baz')
+			.reply(200, {
+				data: {
+					'got': 'ok'
+				}
+			});
+
+		var api = new Api({url: url});
+		var promise = api.request(path, params, null, method);
+		expect(promise).to.eventually.deep.equal({'got': 'ok'}).and.notify(done);
+	});
+
+
+	it('should resolve returned promise with data if everything went ok (without fields and params)', function(done) {
+		var url = 'http://foobar:8080',
+			path = '/test',
+			method = 'GET';
+
+		nock(url)
+			.get('/attask/api' + path)
+			.reply(200, {
+				data: {
+					'got': 'ok'
+				}
+			});
+
+		var api = new Api({url: url});
+		var promise = api.request(path, null, null, method);
+		expect(promise).to.eventually.deep.equal({'got': 'ok'}).and.notify(done);
+	});
+
+
+	it('should resolve returned promise with data if everything went ok (path without leading /)', function(done) {
+		var url = 'http://foobar:8080',
+			path = 'test',
+			params = {
+				'foo': 1,
+				'bar': 'baz'
+			},
+			fields = [],
+			method = 'GET';
+
+		nock(url)
+			.get('/attask/api/' + path + '?foo=1&bar=baz')
+			.reply(200, {
+				data: {
+					'got': 'ok'
+				}
+			});
+
+		var api = new Api({url: url});
+		var promise = api.request(path, params, fields, method);
+		expect(promise).to.eventually.deep.equal({'got': 'ok'}).and.notify(done);
+	});
+
+
 	it('should reject returned promise with error data on error', function(done) {
 		var url = 'http://foobar:8080',
 			path = '/test',