fix: Api.execute method for namedAction should make request with POST instead of PUT

Author: citizensas

src/Api.ts

@@ -194,10 +194,16 @@ export class Api {
             endPoint += '/' + objID + '/' + action
         }
         else {
-            actionArgs = actionArgs || {}
-            actionArgs['action'] = action
+            endPoint += '?method='+ Api.Methods.PUT +'&action=' + action
         }
-        return this.request(endPoint, actionArgs, null, Api.Methods.PUT)
+        const JSONstringifiedArgs = JSON.stringify(actionArgs)
+        let params = null
+        if (JSONstringifiedArgs) {
+            params = {
+                updates: JSONstringifiedArgs
+            }
+        }
+        return this.request(endPoint, params, null, Api.Methods.POST)
     }
 
     /**
@@ -364,7 +370,7 @@ export class Api {
                 a.push(k + '=' + encodeURIComponent(params[k]))
                 return a
             }, []).join('&')
-            if (method === Api.Methods.GET || method === Api.Methods.PUT) {
+            if (method === Api.Methods.GET) {
                 if (bodyParams) {
                     queryString = '?' + bodyParams
                 }

test/integration/edit.spec.ts

@@ -55,8 +55,8 @@ describe('Edit', function() {
         return this.api.edit(objCode, objID, params).then(function(data) {
             const [url, opts] = fetchMock.lastCall('edit')
             should(opts.method).equal('PUT')
-            should(url).endWith(objCode + '/' + objID + '?name=' + encodeURIComponent('api test 2'))
-            should(opts.body).be.null()
+            should(url).endWith(objCode + '/' + objID)
+            should(opts.body).containEql('name=' + encodeURIComponent('api test 2'))
 
             should(data).have.properties(['ID', 'name', 'objCode'])
             should(data.objCode).equal(objCode)

test/integration/execute.spec.ts

@@ -49,35 +49,36 @@ describe('Execute', function() {
         return this.api.execute('foo', 'bar', 'baz').then(function(data) {
             const [url, opts] = fetchMock.lastCall('execute')
             should(url).endWith('foo/bar/baz')
-            should(opts.method).equal('PUT')
+            should(opts.method).equal('POST')
         })
     })
 
     it('should call request() with proper params (with args)', function() {
         return this.api.execute('foo', 'bar', 'baz', {foo: 'barbaz'}).then(function(data) {
             const [url, opts] = fetchMock.lastCall('execute')
-            should(url).containEql('foo/bar/baz')
-            should(url).containEql('foo=barbaz')
-            should(opts.body).be.null()
-            should(opts.method).equal('PUT')
+            should(url).endWith('foo/bar/baz')
+            should(opts.body).containEql(`updates=${encodeURIComponent(JSON.stringify({foo: 'barbaz'}))}`)
+            should(opts.method).equal('POST')
         })
     })
 
     it('should call request() with proper params (with args) when objID is omitted', function() {
         return this.api.execute('foo', null, 'baz', {foo: 'barbaz'}).then(function(data) {
             const [url, opts] = fetchMock.lastCall('execute')
-            should(url).endWith('foo?foo=barbaz&action=baz')
-            should(opts.body).be.null()
-            should(opts.method).equal('PUT')
+            should(url).containEql('method=PUT')
+            should(url).containEql('action=baz')
+            should(opts.body).containEql(`updates=${encodeURIComponent(JSON.stringify({foo: 'barbaz'}))}`)
+            should(opts.method).equal('POST')
         })
     })
 
     it('should call request() with proper params (without args) when objID is omitted', function() {
         return this.api.execute('foo', null, 'baz').then(function(data) {
             const [url, opts] = fetchMock.lastCall('execute')
-            should(url).endWith('foo?action=baz')
-            should(opts.body).be.null()
-            should(opts.method).equal('PUT')
+            should(url).containEql('action=baz')
+            should(url).containEql('method=PUT')
+            should(opts.body).not.be.ok()
+            should(opts.method).equal('POST')
         })
     })
 })