Skip to content

refactor: upgrade deps, switch to lefthook, fix tests#1016

Merged
citizensas merged 6 commits intomasterfrom
master-hb-tests-fix
Jan 10, 2022
Merged

refactor: upgrade deps, switch to lefthook, fix tests#1016
citizensas merged 6 commits intomasterfrom
master-hb-tests-fix

Conversation

@bhovhannes
Copy link
Copy Markdown
Member

@bhovhannes bhovhannes commented Jan 10, 2022

karma-typescript is not working with TS 4.5.4, thus downgraded to TS 4.4.4 until this will be fixed. See monounity/karma-typescript#499 for more details.

Also remove IE11, non-Chromium Edge, Safari 9 and Linux Chrome (it was using v48) from the soucelabs test matrix. These browsers are outdated and fetch-mock UMD build does not work under these browsers because of incompatible syntax.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 10, 2022

Codecov Report

Merging #1016 (949311b) into master (18ee632) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1016   +/-   ##
=======================================
  Coverage   84.01%   84.01%           
=======================================
  Files           1        1           
  Lines         269      269           
  Branches       61       61           
=======================================
  Hits          226      226           
  Misses         29       29           
  Partials       14       14           
Impacted Files Coverage Δ
src/Api.ts 84.01% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31792b2...949311b. Read the comment docs.

@citizensas citizensas merged commit dcb1cf5 into master Jan 10, 2022
@citizensas citizensas deleted the master-hb-tests-fix branch January 10, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants