Skip to content

Conversation

@travissanderson-wf
Copy link
Contributor

@travissanderson-wf travissanderson-wf commented Jun 12, 2017

Loosen dartdoc range

@travissanderson-wf
Copy link
Contributor Author

@maxwellpeterson-wf can you re-review? I forgot how to pubspec :)

@travissanderson-wf
Copy link
Contributor Author

@jayudey-wf any idea what is up with that test? it passes locally and in Smithy, maybe travis-ci is on an old Dart SDK?

@travissanderson-wf
Copy link
Contributor Author

@travissanderson-wf
Copy link
Contributor Author

hmm allegedly that is the same as Smithy though.. I bumped it up to 1.23.0, I guess we shall see..

@codecov-io
Copy link

Codecov Report

Merging #225 into master will decrease coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
- Coverage   21.63%   21.38%   -0.26%     
==========================================
  Files           7        7              
  Lines         171      173       +2     
==========================================
  Hits           37       37              
- Misses        134      136       +2
Impacted Files Coverage Δ
lib/src/util.dart 35.71% <0%> (ø) ⬆️
lib/src/platform_util/standard_platform_util.dart 0% <0%> (ø) ⬆️
lib/src/task_process.dart 51.16% <0%> (ø) ⬆️
lib/src/tools/selenium.dart 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1dec8b...90882df. Read the comment docs.

@travissanderson-wf
Copy link
Contributor Author

maybe an intermittent timeout? it passed this time

@Workiva Workiva deleted a comment from rmconsole2-wf Jun 13, 2017
@rmconsole2-wf rmconsole2-wf changed the title Loosen dartdoc range WP-4404 Loosen dartdoc range Jun 13, 2017
@maxwellpeterson-wf
Copy link
Member

+10

  • CI passed

@maxwellpeterson-wf
Copy link
Member

QA +1

  • Minimum dependency bump only
  • Dev +1's
  • CI passes
  • Dependency scan clean

@Workiva/release-management-pp

@rmconsole-wf
Copy link
Contributor

+1 from RM

@rmconsole-wf rmconsole-wf merged commit f24cfba into Workiva:master Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants