-
Notifications
You must be signed in to change notification settings - Fork 40
WP-4404 Loosen dartdoc range #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@maxwellpeterson-wf can you re-review? I forgot how to pubspec :) |
|
@jayudey-wf any idea what is up with that test? it passes locally and in Smithy, maybe travis-ci is on an old Dart SDK? |
|
oh yeah it is on 1.19.1! https://github.com/Workiva/dart_dev/blob/master/.travis.yml#L3 |
|
hmm allegedly that is the same as Smithy though.. I bumped it up to 1.23.0, I guess we shall see.. |
Codecov Report
@@ Coverage Diff @@
## master #225 +/- ##
==========================================
- Coverage 21.63% 21.38% -0.26%
==========================================
Files 7 7
Lines 171 173 +2
==========================================
Hits 37 37
- Misses 134 136 +2
Continue to review full report at Codecov.
|
|
maybe an intermittent timeout? it passed this time |
|
+10
|
|
QA +1
@Workiva/release-management-pp |
|
+1 from RM |
Loosen dartdoc range