Skip to content

Conversation

@jayudey-wf
Copy link
Contributor

Issue

  • There was no way to run tests with the dart dev compiler (or really any web-compiler).

Changes

Source:

  • Added a pass through flag that allowed the web-compiler to be specified for the test task.

Tests:

  • added

Areas of Regression

  • failing tests

Testing

  • passing CI
  • install locally and verify that passing in a flag to the test task appropriately updates the serve task

Code Review

@Workiva/web-platform-pp
@Workiva/ui-platform-pp

@aviary-wf
Copy link

aviary-wf commented Aug 8, 2017

Raven

Number of Findings: 0

@rmconsole2-wf rmconsole2-wf changed the title Allow web-compiler flag to be passed through dart_dev to test task WP-4898 Allow web-compiler flag to be passed through dart_dev to test task Aug 8, 2017
@codecov-io
Copy link

Codecov Report

Merging #235 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #235   +/-   ##
=======================================
  Coverage   21.38%   21.38%           
=======================================
  Files           7        7           
  Lines         173      173           
=======================================
  Hits           37       37           
  Misses        136      136

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c907bae...6ea1964. Read the comment docs.

@greglittlefield-wf
Copy link
Contributor

  • CI Passes
  • Works as expected when --web-compiler flag is specified locally

+10

@jayudey-wf
Copy link
Contributor Author

jayudey-wf commented Aug 8, 2017

QA +1

  • Testing instruction
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
    • performed and documented by Greg
  • Security review (if required)
  • Unit tests created/updated
  • All unit tests pass
  • Rosie has run and reports properly the release the ticket will be included in

Merging into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants