Skip to content

Conversation

@aaronlademann-wf
Copy link
Contributor

Pretty self-explanatory. There is no usage of the sass package in this repo.

@Workiva/web-platform-pp @Workiva/ui-platform-pp

@jacehensley-wf
Copy link
Contributor

+1

@codecov-io
Copy link

Codecov Report

Merging #238 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #238   +/-   ##
=======================================
  Coverage   21.38%   21.38%           
=======================================
  Files           7        7           
  Lines         173      173           
=======================================
  Hits           37       37           
  Misses        136      136

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0888cc5...1223164. Read the comment docs.

@jacehensley-wf
Copy link
Contributor

+1

@rmconsole3-wf rmconsole3-wf changed the title Remove unnecessary dependency on sass package WP-5353 Remove unnecessary dependency on sass package Oct 18, 2017
@evanweible-wf
Copy link
Contributor

+10

  • CI passes

@evanweible-wf
Copy link
Contributor

QA +1

  • Testing instruction
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
  • All unit tests pass

Merging into master.

@evanweible-wf evanweible-wf merged commit 2fd1fca into master Oct 18, 2017
@evanweible-wf evanweible-wf deleted the remove-sass-dependency branch October 18, 2017 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants