Skip to content

Conversation

@johnbland-wf
Copy link
Contributor

Upgrade rxdart to the latest.

@codecov-io
Copy link

codecov-io commented Oct 31, 2017

Codecov Report

Merging #240 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #240   +/-   ##
=======================================
  Coverage   21.38%   21.38%           
=======================================
  Files           7        7           
  Lines         173      173           
=======================================
  Hits           37       37           
  Misses        136      136

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0ccc73...7724a73. Read the comment docs.

pubspec.yaml Outdated
platform_detect: ^1.3.2
resource: '>=1.0.0 <3.0.0'
rxdart: ^0.12.0
rxdart: ^0.14.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could just expand the version range

rxdart: '>=0.12.0 <0.15.0'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@jacehensley-wf
Copy link
Contributor

+1

@jayudey-wf
Copy link
Contributor

QA +1 , dependency only change

  • passing CI

Merging into master

@jayudey-wf
Copy link
Contributor

+1 @Workiva/release-management-pp

@rmconsole-wf
Copy link
Contributor

+1 from RM

@rmconsole-wf rmconsole-wf merged commit 1014163 into Workiva:master Oct 31, 2017
@johnbland-wf johnbland-wf deleted the upgrade_rxdart branch October 31, 2017 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants